Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound checks for numbers #154

Open
clearloop opened this issue Oct 21, 2023 · 1 comment · Fixed by sobuur0/zink#1 · May be fixed by #282
Open

Bound checks for numbers #154

clearloop opened this issue Oct 21, 2023 · 1 comment · Fixed by sobuur0/zink#1 · May be fixed by #282
Assignees
@sobuur0
Labels
budget-$100 Payable medium onboarding issues security Security Issue
Milestone
v0.2.0 - Solidity...

Comments

@clearloop
Copy link
Member

clearloop commented Oct 21, 2023 •
edited
Loading

Describe the feature

for example,

fn addition(x: i32) -> i32 {
  x + i32::MAX
}
  • Introduce bound checks for i32, u32, i64 and u64, use 'zink::revert!' on overflow
  • tests are required, introduce a new test in examples for doing it

Solution

No response
@clearloop clearloop added the security Security Issue label Oct 22, 2023
@clearloop clearloop mentioned this issue Oct 31, 2024
Open
@clearloop clearloop added budget-$50 Payable small onboarding issues budget-$100 Payable medium onboarding issues and removed budget-$50 Payable small onboarding issues labels Nov 26, 2024
@sobuur0
Copy link

sobuur0 commented Nov 26, 2024

@clearloop assign me

This was referenced Nov 27, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobuur0 sobuur0

Labels
budget-$100 Payable medium onboarding issues security Security Issue
Projects
The End Game
Status: No status
Milestone
v0.2.0 - Solidity Feature Parity
2 participants
@clearloop @sobuur0