Arbitrary arity tuple #435
Merged
+304
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Primetalk
force-pushed
the
arbitrary-arity-tuple
branch
2 times, most recently
from
a62ad2a
to
a2f11a1
Compare
Primetalk
force-pushed
the
arbitrary-arity-tuple
branch
from
c81a9ea
to
306c524
Compare
Primetalk
force-pushed
the
arbitrary-arity-tuple
branch
from
2c2fc94
to
8690ffa
Compare
guizmaii
reviewed
May 8, 2024
| '{EmptyTuple} | ||
| } else if (tpe <:< TypeRepr.of[Tuple]) { | ||
| '{scala.runtime.Tuples.fromIArray(IArray(${Varargs(terms)})).asInstanceOf[T]} | ||
| // Alternative version: |
There was a problem hiding this comment.
I wanted to consult which version is preferred - array based or recursion-based.
Primetalk
commented
May 8, 2024
| t match { | ||
| case | ||
| Inlined( | ||
| // Some(Apply( |
There was a problem hiding this comment.
Question: should we also match on call part or is it enough to match just the body?
|
This is really amazing work! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
Problem
To support Scala 3-style tuples, a few changes are needed:
*:) inside quotes.Solution
So far Quat and decoding are implemented.
There are two variants of decoding:
The latter might be more performant.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progress@getquill/maintainers