-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 214 and 205 #290
Issue 214 and 205 #290
Conversation
@robmwalsh could you coordinate 🙏 ? Solves similar problem to #263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work here @antoniograndinetti! A few things to fix up, mainly relating to types. You've stumbled into some of the slightly more complicated type machinery here - I've tried to explain the relevant bits but feel free to ask if anything's unclear.
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here @antoniograndinetti - just a few more things to go to make the parenless functions parenless in our DSL as well, and a bit of extra type safety
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
postgres/src/test/scala/zio/sql/postgresql/FunctionDefSpec.scala
Outdated
Show resolved
Hide resolved
Awesome work here @antoniograndinetti! Thanks for your contribution |
Issue 214 and 205
Fixes #214
Fixes #205