Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Better examples for reading a zip #415

Closed
xTachyon opened this issue Nov 13, 2023 · 1 comment
Closed

Better examples for reading a zip #415

xTachyon opened this issue Nov 13, 2023 · 1 comment

Comments

@xTachyon
Copy link

My guess is that the most common case for using a zip crate is to read a zip file. Given this assumption, I feel like one of the first things the user should see on the docs on docs.rs is an example of reading a zip file and printing the file names, or something of the sort. The examples directory is good, but it's not mentioned at all on docs.rs.

Another thing that isn't immediately obvious is that the crate does no buffering whatsoever, and the user should probably use a BufReader when reading from a File. In my case, the unbuffered version took 11s to new the object, while the buffered version took only about 500ms.

@Pr0methean
Copy link
Member

This repo is no longer maintained. This issue has been partly resolved by zip-rs/zip2#55 and should be fully resolved by zip-rs/zip2#56, zip-rs/zip2#59 and zip-rs/zip2#67.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants