Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Invalid locale prevents userinfo lookup #672

Closed
2 tasks done
muir opened this issue Oct 31, 2024 · 1 comment · Fixed by #673
Closed
2 tasks done

[Bug]: Invalid locale prevents userinfo lookup #672

muir opened this issue Oct 31, 2024 · 1 comment · Fixed by #673
Labels
bug Something isn't working

Comments

@muir
Copy link
Contributor

muir commented Oct 31, 2024

Preflight Checklist

  • I could not find a solution in the documentation, the existing issues or discussions
  • I have joined the ZITADEL chat

Version

v3.27.0

Describe the problem caused by this bug

The userinfo call is failing due to an marshal problem with the locale. I don't care about locale. At all. I do care that a paying customer cannot log in.

To reproduce

I'm not sure what value is being presented by Okta. Their IT says that all their users have locale=null but somehow some can log in and others cannot.

Screenshots

No response

Expected behavior

Ignore locale if it's not avalid

Additional Context

I'll propose a fix to ignore all unmarshal errors with locale.

@muhlemmer
Copy link
Collaborator

I'm not sure what value is being presented by Okta. Their IT says that all their users have locale=null but somehow some can log in and others cannot.

Yet, it would be really good to know what they are sending. JSON null works. Don't tell me those muppets are sending a quoted "null" string.

On a side note, for your future debugging efforts, we have added the Error.WithReturnParentToClient which can help understanding these type of errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants