Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake option should not be used for strings #23

Open
knatten opened this issue Nov 5, 2019 · 0 comments
Open

CMake option should not be used for strings #23

knatten opened this issue Nov 5, 2019 · 0 comments

Comments

@knatten
Copy link
Contributor

knatten commented Nov 5, 2019

In CMakeLists.txt we use option for ZIVID_PYTHON_VERSION and ZIVID_SDK_VERSION. option is only meant for booleans, we should use set instead.

Suggested fix:

set(ZIVID_PYTHON_VERSION "UNKNOWN" CACHE  STRING "Version number to be compiled into the module")
set(ZIVID_SDK_VERSION "0.0.0" CACHE STRING "Zivid SDK version to link with")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knatten