fix: update permissionless paymaster tutorial & l1-l2 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbionaHoti
changed the title
|
Visit the preview URL for this PR (updated for commit 8cc4e8c): https://community-cookbook-staging--pr47-fix-update-permissio-3u5ffkca.web.app (expires Fri, 30 Aug 2024 17:42:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1b876338aafcf55b4a02f1877984e116731756b1 |
AlbionaHoti
changed the title
bxpana
reviewed
Aug 23, 2024
|
|
||
| 3. The signer's key signs this paymaster data and returns the signature and signer address to the Dapp's frontend. | ||
|
|
||
| 4. Paymaster address and required data with signature are added to the transaction blob in the frontend. | ||
|
|
||
| 5. User gets transaction signature request pop-up on their wallet. **User only signs the transaction** and the transaction is sent on-chain. | ||
| 5. The user receives the transaction signature request pop-up on their wallet. **The User only signs the transaction**, and it is sent on-chain. |
There was a problem hiding this comment.
Change **The User to **The user for consistency
| @@ -357,7 +364,7 @@ const preparePaymasterParam = async (account:any, estimateGas: BigNumber) =>{ | |||
|
|
|||
| // Estimate gas | |||
| const estimateGas = await contract.estimateGas.approve(spender,amount); | |||
| const [paymasterParams, maxFeePerGas, gasLimit] = await preparePaymasterParam(account, estimateGas); | |||
| const [account, paymasterParams, maxFeePerGas, gasLimit] = await preparePaymasterParam(account, estimateGas); | |||
There was a problem hiding this comment.
This would lead to error.
| // -------------- | ||
| const tx = await contract.approve(spender, amount); | ||
|
|
||
| const [account, paymasterParams, maxFeePerGas, gasLimit] = await preparePaymasterParam(account, estimateGas); |
There was a problem hiding this comment.
This would lead to error
itsacoyote
reviewed
Aug 23, 2024
|
|
||
| 2. Dapp calls the backend server or Zyfi API with relevant data to get the signer's signature. | ||
| - It is recommended that the signer's signing part is done on a secure backend server of the Dapp. | ||
| For the utmost security, it is recommended that the signer's signature be sent to Dapp's secure backend server. |
There was a problem hiding this comment.
Suggested change
| For the utmost security, it is recommended that the signer's signature be sent to Dapp's secure backend server. | |
| For security best-practices, it is recommended to create the signer's signature on a secure backend server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description