OpenZeppelin Clones CREATE2 keeps failing

[sebastiantf]

Environment

Testnet

Provide a brief description of the functionality you're trying to implement.

We have a factory contract that deploys ERC-1167 Minimal Proxy contracts using the OpenZeppelin's Clones library which also uses CREATE2 for deployment of these proxies.

What is the specific issue or error you're encountering?

I keep getting the error ProviderError: execution reverted: ERC1167: create2 failed

Can you share the error messages or logs you're receiving, if any?

Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="execution reverted: ERC1167: create2 failed", method="estimateGas", transaction={"from":"0xFB5b21C1d090D40A29cd7BB9BbE3eBA9e8f06b91","to":"0x65C3745607B8e9838EdbEAFBD4E2da4009ec16B1","value":{"type":"BigNumber","hex":"0x00"},"data":"0x9778f5b5000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000000000000000000000000000000000000000018000000000000000000000000000000000000000000000000000000000000002000000000000000000000000001c834eb52c30ce5b77d40373f750b0da1563d05c000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000018ad04640b7000000000000000000000000000000000000000000000000000000000000000954657374546f6b656e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000454455354000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042697066733a2f2f6261666b726569626e376f6976746774637233716c6d6d756b6f7a677863666d69796a65367573636a336870336e6a727a34626536757870656d710000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042697066733a2f2f6261666b72656967783770346f37676b77616574336e6f6678376132747a646b7a7168347a68726133337174796c346b756164756e3334337a3534000000000000000000000000000000000000000000000000000000000000","accessList":null}, error={"name":"ProviderError","_stack":"ProviderError: execution reverted: ERC1167: create2 failed\n    at HttpProvider.request (node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/hardhat/src/internal/core/providers/http.ts:88:21)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async EthersProviderWrapper.send (node_modules/.pnpm/@[email protected][email protected][email protected]/node_modules/@nomiclabs/hardhat-ethers/src/internal/ethers-provider-wrapper.ts:13:20)","code":3,"_isProviderError":true,"data":"0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000017455243313136373a2063726561746532206661696c6564000000000000000000"}, code=UNPREDICTABLE_GAS_LIMIT, version=providers/5.7.2)
    at Logger.makeError (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/logger/src.ts/index.ts:269:28)
    at Logger.throwError (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/logger/src.ts/index.ts:281:20)
    at checkError (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:78:20)
    at EthersProviderWrapper.<anonymous> (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:642:20)
    at step (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:48:23)
    at Object.throw (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:29:53)
    at rejected (node_modules/.pnpm/@[email protected]/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:21:65)
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  reason: 'execution reverted: ERC1167: create2 failed',
  code: 'UNPREDICTABLE_GAS_LIMIT',
  method: 'estimateGas',
  transaction: {
    from: '0xFB5b21C1d090D40A29cd7BB9BbE3eBA9e8f06b91',
    to: '0x65C3745607B8e9838EdbEAFBD4E2da4009ec16B1',
    value: BigNumber { value: "0" },
    data: '0x9778f5b5000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000000000000000000000000000000000000000018000000000000000000000000000000000000000000000000000000000000002000000000000000000000000001c834eb52c30ce5b77d40373f750b0da1563d05c000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000018ad04640b7000000000000000000000000000000000000000000000000000000000000000954657374546f6b656e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000454455354000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042697066733a2f2f6261666b726569626e376f6976746774637233716c6d6d756b6f7a677863666d69796a65367573636a336870336e6a727a34626536757870656d710000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042697066733a2f2f6261666b72656967783770346f37676b77616574336e6f6678376132747a646b7a7168347a68726133337174796c346b756164756e3334337a3534000000000000000000000000000000000000000000000000000000000000',
    accessList: null
  },
  error: ProviderError: execution reverted: ERC1167: create2 failed
      at HttpProvider.request (node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/hardhat/src/internal/core/providers/http.ts:88:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async EthersProviderWrapper.send (node_modules/.pnpm/@[email protected][email protected][email protected]/node_modules/@nomiclabs/hardhat-ethers/src/internal/ethers-provider-wrapper.ts:13:20)
}

Tried using the exploere and failed. Sample Txn with same calldata: https://goerli.explorer.zksync.io/tx/0xf0f2d853430b6bc87222e68b805e2ae8898f0b0f3125d7f7ff8e0ca250cae07d#overview

Have you made any recent changes to the contract before encountering this issue?

No

Are there any external libraries or contracts that your contract interacts with?

OpenZeppelin's Clones library v4.8.0

Can you provide the relevant portions of your contract code where the issue is occurring?

The relevant code from the Clones library is this:

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/49c0e4370d0cc50ea6090709e3835a3091e33ee2/contracts/proxy/Clones.sol#L45-L56

    function cloneDeterministic(address implementation, bytes32 salt) internal returns (address instance) {
        /// @solidity memory-safe-assembly
        assembly {
            // Cleans the upper 96 bits of the `implementation` word, then packs the first 3 bytes
            // of the `implementation` address with the bytecode before the address.
            mstore(0x00, or(shr(0xe8, shl(0x60, implementation)), 0x3d602d80600a3d3981f3363d3d373d3d3d363d73000000))
            // Packs the remaining 17 bytes of `implementation` with the bytecode after the address.
            mstore(0x20, or(shl(0x78, implementation), 0x5af43d82803e903d91602b57fd5bf3))
            instance := create2(0, 0x09, 0x37, salt)
        }
        require(instance != address(0), "ERC1167: create2 failed");
    }

Have you tried to isolate the problem, and if so, what were the results?

Not yet

What steps have you already taken to try to resolve the issue?

I went through the docs regarding the CREATE, CREATE2 differences. But I am still unsure if its not possible to use the type of code used in OpenZeppelin's Clones library

Repo Link (Optional)

private monorepo

Additional Details

No response

[sebastiantf]

Duplicate of #91