Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests can't compile due to rayon MSRV update without new minor bump #112

Closed
CPerezz opened this issue Sep 7, 2023 · 3 comments
Closed

Comments

@CPerezz
Copy link

CPerezz commented Sep 7, 2023

If you try to run the tests for this lib, you'll see that you get:

error: package rayon-core v1.11.0 cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0

This is due to the fact that:

❯ cargo tree -i rayon-core       
rayon-core v1.11.0
└── rayon v1.7.0
    └── criterion v0.3.6
        [dev-dependencies]
        └── bls12_381 v0.8.0 

As you can see here, criterion depends on rayon_core with ^0.3. After rayon moved up MSRV without bumping minor version, everything broke.

We might want to either:

  • Bump MSRV.
  • Fix Cargo.lock (doesn't make any sense to me as this is a lib).
  • Downgrade Criterion in hopes it uses a version of rayon compatible with rustc 1.56.0 or older.

@str4d let me know what you prefer and I'll push a PR.

CPerezz added a commit to CPerezz/bls12_381 that referenced this issue Sep 8, 2023
In order to solve:
`error: package `rayon-core v1.11.0` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0`

This is due to the fact that:
```
❯ cargo tree -i rayon-core
rayon-core v1.11.0
└── rayon v1.7.0
    └── criterion v0.3.6
        [dev-dependencies]
        └── bls12_381 v0.8.0
```

As you can see here, `criterion` depends on `rayon_core` with `^0.3`. After `rayon` moved up MSRV without bumping minor version, everything broke.

This bumps the MSRV to 1.59 fixing this issue. See: zkcrypto#112
@CPerezz
Copy link
Author

CPerezz commented Sep 8, 2023

After bumping to 1.59, I saw the following:
error: package regex-syntax v0.7.2 cannot be built because it requires rustc 1.60.0 or newer, while the currently active rustc version is 1.59.0

cargo tree -i regex-syntax
regex-syntax v0.7.2
└── regex v1.8.4
    └── criterion v0.3.6
        [dev-dependencies]
        └── bls12_381 v0.8.0

It seems same thing happened as with rayon_core. Bumping to 1.60.0 solves all the issues.

@HDauven
Copy link

HDauven commented Oct 17, 2023

I'm not sure what version rayon-core is set at, but from v1.12.0 it requires at least rustc 1.63.

It would be nice if either your PR #113 and #116 were applied, or the versions locked.

@str4d
Copy link
Member

str4d commented Jul 21, 2024

  • Fix Cargo.lock (doesn't make any sense to me as this is a lib).

As of just over a week prior to this issue being opened, the recommendation for libraries is now to check in Cargo.lock if you are trying to maintain an MSRV. I did this in #135, and tests now work again.

@str4d str4d closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants