-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests can't compile due to rayon MSRV update without new minor bump #112
Comments
In order to solve: `error: package `rayon-core v1.11.0` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0` This is due to the fact that: ``` ❯ cargo tree -i rayon-core rayon-core v1.11.0 └── rayon v1.7.0 └── criterion v0.3.6 [dev-dependencies] └── bls12_381 v0.8.0 ``` As you can see here, `criterion` depends on `rayon_core` with `^0.3`. After `rayon` moved up MSRV without bumping minor version, everything broke. This bumps the MSRV to 1.59 fixing this issue. See: zkcrypto#112
After bumping to
It seems same thing happened as with |
As of just over a week prior to this issue being opened, the recommendation for libraries is now to check in |
If you try to run the tests for this lib, you'll see that you get:
error: package
rayon-core v1.11.0cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0
This is due to the fact that:
As you can see here,
criterion
depends onrayon_core
with^0.3
. Afterrayon
moved up MSRV without bumping minor version, everything broke.We might want to either:
rayon
compatible withrustc 1.56.0
or older.@str4d let me know what you prefer and I'll push a PR.
The text was updated successfully, but these errors were encountered: