Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero point for SWJacobian #29

Open
DanieleDiBenedetto opened this issue Dec 12, 2019 · 1 comment
Open

Zero point for SWJacobian #29

DanieleDiBenedetto opened this issue Dec 12, 2019 · 1 comment

Comments

@DanieleDiBenedetto
Copy link

Hi, shouldn't the zero point in SW Jacobian be any point of the form (t^2:t^3:0) with t <> 0 (conventionally represented with (1:1:0)), instead of (0:1:0), which is actually the zero point in SWProjective ?

pub fn identity() -> G1Projective {

@ebfull
Copy link
Contributor

ebfull commented Dec 14, 2019

Originally the code was using projective formulas, and I actually think I might switch to them (after some benchmarks) but I wanted to have an implementation with Jacobian to benchmark against after other optimizations have been written, that way I know it's worth it. (#2)

The choice of representation here doesn't matter though. The API does not provide access to the raw coordinates, so this can be switched later without breaking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants