-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevating u128-support to default #80
Comments
The lowering is definitely incomplete today. Last I was working on it it could lower the operators, but a bunch of platforms didn't have support for passing and returning |
Please don't remove nightly/beta from CI. It'll help make sure we don't regress anything you depend on without knowing it. |
Okay. BTW My CI only tests against nightly when we merge PR's, which isn't that often. |
I'd like to use
u128
only in this library and remove the backup arithmetic, but only if its arithmetic is lowered properly on target platforms that don't support it.My ideal strategy:
feature(i128_type)
invocation, since it is no longer needed on nightly or (eventually) the1.26 beta
compiler. Do patch release.1.26
stable is released, change documentation to remove mentions of nightly. CI can be changed to always target stable, except for clippy. (See Change CI to compile on latest nightly #45)u128
lowering definitely works, remove backup arithmetic and use u128-support arithmetic only. Theu128-support
feature will do nothing. In the next minor release, remove theu128-support
feature.The text was updated successfully, but these errors were encountered: