Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country public keys #84

Open
Divide-By-0 opened this issue May 6, 2024 · 4 comments
Open

Add country public keys #84

Divide-By-0 opened this issue May 6, 2024 · 4 comments
Labels
enhancement New feature or request medium

Comments

@Divide-By-0
Copy link
Member

Divide-By-0 commented May 6, 2024

We can make this a more general public key registry, by also supporting ICAO country public keys. This will require making some scripts to hit and parse those URLs, and also noting all existing keys as RSA and the new keys as ECDSA/RSA etc as needed. Note that while many keys are on ICAO's PKD, many are on country-specific sites.

@Divide-By-0 Divide-By-0 added enhancement New feature or request medium labels May 6, 2024
@Divide-By-0
Copy link
Member Author

The parsing logic can be found here: https://github.com/zk-passport/proof-of-passport/tree/main/registry

The key download sites are here: https://download.pkd.icao.int/

@foolo
Copy link
Contributor

foolo commented May 17, 2024

As a preparation, I think we need to extend the database structure for this. At the moment there are only DomainSelectorPair and DkimRecord (each DomainSelectorPair has many DkimRecords). So we should think about what would be the best solution here.

@foolo
Copy link
Contributor

foolo commented Jun 12, 2024

Related: zk-passport/openpassport#110

@foolo
Copy link
Contributor

foolo commented Jun 17, 2024

Florent, [2024-06-15 17:46]
you can see the latest version of our code to parse certificates from the ICAO list here:
https://github.com/zk-passport/proof-of-passport/tree/dev/registry

Florent, [2024-06-15 17:47]
And we recently shipped this map that for now only contains DSCs but will soon contain CSCAs
https://map.proofofpassport.com/
For context there are two levels of certificates, top ones (CSCAs) and intermediate ones that sign passports (DSCs)

https://github.com/zk-passport/proof-of-passport/tree/dev/registry
Florent, [2024-06-15 17:49]
by running the scripts here you should be able to get all the certificates, DSCs and CSCAs from the ICAO registry.
It’s on the dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium
Projects
None yet
Development

No branches or pull requests

2 participants