-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert state changes for script tests #65
Comments
hi , i am applying for the smart contract role and will be taking on this issue |
Hey @mahmudsudo, great |
i have also sent the email also as required |
@JohnGuilding , please review it. I am looking to smart contract role and this opportunity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per the foundry docs, tests for deployment scripts should assert on the state changes made by the script. This issue is concerned with modifying the following tests to assert against all state changes in our scripts including branching logic:
require
statements to assert that the expected address is correct, this work would include calculating expected addresses:require(computedAddress == deployedAddress, "address mismatch")
The text was updated successfully, but these errors were encountered: