-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emails with emojis fail proving #15
Comments
After debugging and checking the code https://github.com/zkemail/zk-email-verify/blob/dca512e8b6b21020d68cbc8091610e7da78c420a/packages/helpers/src/dkim/index.ts#L18 I found the issue should be caused by the emoji on my Twitter name. I tried other tools like https://www.appmaildev.com/en/dkimfile, but it shows DKIM failed too. So it should not be an issue in zkemail. But I would suggest adding tips on the page as many buidlers might add emoji like 🦇🔊 on their Twitter name. Btw, I tested with another Twitter account without emoji, the proof generated and verified successfully, but no response after clicking the "Mint Twitter badge on-chain", my friend also encountered the same issue. Still debugging on this one. Weird. |
Well... After debugging, find the there is a "Connect Wallet" on the top, need to connect wallet first. I think the UI could be improved, if not connected the button should be disabled or indicate connect first. |
UI/UX improvements for fixing issue #15
@brucexu-eth For the email with emoji in the username, can you please try by downloading as I have a noticed that text encoding breaks when gmail display the raw content in "Show Original" page in some cases. If this is the case, we can update the instruction to use eml file instead. |
I tried https://twitter.prove.email/, and steps 1, 2,3, and 4 are done. But the step 5 seems to be incorrect:
First, I didn't find a button called "Generate Proof" in the instruction, might it be "Proof"?
Second, after clicking the "Prove" button below, it shows "Error verifying DKIM". But it is indeed a valid original message I copied from Gmail. Debugging the code...
The text was updated successfully, but these errors were encountered: