Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails with emojis fail proving #15

Open
brucexu-eth opened this issue Mar 25, 2024 · 3 comments
Open

Emails with emojis fail proving #15

brucexu-eth opened this issue Mar 25, 2024 · 3 comments

Comments

@brucexu-eth
Copy link
Contributor

brucexu-eth commented Mar 25, 2024

I tried https://twitter.prove.email/, and steps 1, 2,3, and 4 are done. But the step 5 seems to be incorrect:

image

First, I didn't find a button called "Generate Proof" in the instruction, might it be "Proof"?

Second, after clicking the "Prove" button below, it shows "Error verifying DKIM". But it is indeed a valid original message I copied from Gmail. Debugging the code...

@brucexu-eth
Copy link
Contributor Author

After debugging and checking the code https://github.com/zkemail/zk-email-verify/blob/dca512e8b6b21020d68cbc8091610e7da78c420a/packages/helpers/src/dkim/index.ts#L18

I found the issue should be caused by the emoji on my Twitter name.

image

I tried other tools like https://www.appmaildev.com/en/dkimfile, but it shows DKIM failed too. So it should not be an issue in zkemail. But I would suggest adding tips on the page as many buidlers might add emoji like 🦇🔊 on their Twitter name.

Btw, I tested with another Twitter account without emoji, the proof generated and verified successfully, but no response after clicking the "Mint Twitter badge on-chain", my friend also encountered the same issue. Still debugging on this one. Weird.

image

@brucexu-eth
Copy link
Contributor Author

Well... After debugging, find the there is a "Connect Wallet" on the top, need to connect wallet first. I think the UI could be improved, if not connected the button should be disabled or indicate connect first.

Divide-By-0 added a commit that referenced this issue Mar 27, 2024
UI/UX improvements for fixing issue #15
@saleel
Copy link
Member

saleel commented Apr 16, 2024

@brucexu-eth For the email with emoji in the username, can you please try by downloading as .eml file (Gmail "Download Message" instead of "Show Original + copy/paste) and drag/drop the eml file to the UI.

I have a noticed that text encoding breaks when gmail display the raw content in "Show Original" page in some cases. If this is the case, we can update the instruction to use eml file instead.

@Divide-By-0 Divide-By-0 changed the title The online demo doesn't seem to be working Emails with emojis fail proving May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants