Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mopro create improvements #267

Merged
merged 9 commits into from
Dec 11, 2024
Merged

mopro create improvements #267

merged 9 commits into from
Dec 11, 2024

Conversation

alxkzmn
Copy link
Collaborator

@alxkzmn alxkzmn commented Dec 5, 2024

The scope of the PR is to add the functionality to create Flutter and React Native apps using mopro CLI.
Changes:

  • mopro create now contains the options for Flutter and React Native templates;
  • improved error handling in some cases (e.g., more explicit message when a directory exists and cannot be overwritten).

@alxkzmn alxkzmn linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying mopro with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6cc712
Status:⚡️  Build in progress...

View logs

@alxkzmn alxkzmn requested a review from vivianjeng December 5, 2024 08:23
Copy link
Collaborator

@vivianjeng vivianjeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me
Thank you

Comment on lines +75 to +77
print_green_bold(" or VS Code::".to_string());
println!();
print_bold(r" code flutter-app".to_string());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can direct them to read the README in the flutter-app foler
e.g. please follow the fluttter-app/README.md to start the app and replace your circuit
Or link to https://zkmopro.org/docs/setup/flutter-setup
It will be more clear for beginners

Comment on lines +88 to +92
print_green_bold(
" You can now use the following command to open the app in VS Code:".to_string(),
);
println!();
print_bold(r" code react-native-app".to_string());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@vivianjeng vivianjeng merged commit a95b7f7 into main Dec 11, 2024
32 of 33 checks passed
@alxkzmn alxkzmn deleted the 234-mopro-cli-v010 branch December 11, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mopro Cli v0.1.0
2 participants