mz_crypt.h is missing macros like zencode and zdecode which is breaking the compatibility

[ljavorsk]

The crypt.h in the madler/zlib contains macros zencode [1] and zdecode [2] used by some external applications, but these functions are missing in the minizip-ng, thus breaking compatibility.

I've tried to find where they disappeared, and it looks like commit 4138ca5 has removed the whole crypt.h and crypt.c files, then it was replaced by mz_stream_pkcrypt_decode in commit d7814e9, but after that, there must have been some force-push, and the history of removing this function is gone.

[1] https://github.com/madler/zlib/blob/d476828316d05d54c6fd6a068b121b30c147b5cd/contrib/minizip/crypt.h#L77
[2] https://github.com/madler/zlib/blob/d476828316d05d54c6fd6a068b121b30c147b5cd/contrib/minizip/crypt.h#L74

[nmoinvaz]

• Is there a redhat issue/bug open for this?
• What project is this affecting?
• What is the use case for using those two #defines?
• zencode and zdecode are used by static/internal functions, I'm not certain this is expected to be part of the public API.

I am open to pull requests if there is a way it can be shimmed by calling mz_stream_pkcrypt_decode, but my guess is they are using more than just zencode and zdecode from crypt.h.

[yarda]

I hit it when I was trying to compile tcl-9.0.0 with the system zlib, which is now zlib-ng on fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=2318255

Unfortunately, I also wasn't able to compile it with the system zlib-1.2.13-4.fc39. The package bundled zlib-1.3.1 and I don't know whether it would compile with system zlib-1.3.1 (because we don't have it in Fedora) or whether it's just exploiting some internal non public API.

[nmoinvaz]

It appears that TCL has its own internal zip manipulation library and only uses crypt.h for encrypting part.

[nmoinvaz]

I have added a crypt.h to the compat folder. It probably needs testing with distributions to make sure the includes are in the right places.