From 3bcd1aa47b325434515e18baf859acaea32af863 Mon Sep 17 00:00:00 2001
From: Andrew Rosa <dev@andrewhr.io>
Date: Sun, 26 Nov 2023 09:31:31 -0300
Subject: [PATCH] Let `Mongo.Repo` errors flow like with `Mongo` functions
 (#219)

When `Mongo` returns a `Mongo.Error`, we get match errors inside `Enum`,
which are hard to read and sometimes misleading. This patch changes
signatures to let the errors flow. This is argably a breaking change,
but errors will happen anyway in problematic scenario.

As alternative, `Mongo.Error` could be `raise`d and signtures are kept
the same. At least errors will be more clear to library users.
---
 lib/mongo/repo.ex | 43 +++++++++++++++++++++++++------------------
 1 file changed, 25 insertions(+), 18 deletions(-)

diff --git a/lib/mongo/repo.ex b/lib/mongo/repo.ex
index eea7c88d..91346a64 100644
--- a/lib/mongo/repo.ex
+++ b/lib/mongo/repo.ex
@@ -176,45 +176,51 @@ defmodule Mongo.Repo do
       def all(module, filter \\ %{}, opts \\ []) do
         collection = module.__collection__(:collection)
 
-        @topology
-        |> Mongo.find(collection, filter, opts)
-        |> Enum.map(&module.load/1)
+        case Mongo.find(@topology, collection, filter, opts) do
+          {:error, _reason} = error -> error
+          cursor -> Enum.map(cursor, &module.load/1)
+        end
       end
 
       def stream(module, filter \\ %{}, opts \\ []) do
         collection = module.__collection__(:collection)
 
-        @topology
-        |> Mongo.find(collection, module.dump_part(filter), opts)
-        |> Stream.map(&module.load/1)
+        case Mongo.find(@topology, collection, module.dump_part(filter), opts) do
+          {:error, _reason} = error -> error
+          cursor -> Stream.map(cursor, &module.load/1)
+        end
       end
 
       def aggregate(module, pipeline, opts \\ []) do
         collection = module.__collection__(:collection)
 
-        @topology
-        |> Mongo.aggregate(collection, pipeline, opts)
-        |> Enum.map(&module.load/1)
+        case Mongo.aggregate(@topology, collection, pipeline, opts) do
+          {:error, _reason} = error -> error
+          cursor -> Enum.map(cursor, &module.load/1)
+        end
       end
 
       def get(module, id, opts \\ []) do
         collection = module.__collection__(:collection)
 
-        @topology
-        |> Mongo.find_one(collection, %{_id: id}, opts)
-        |> module.load()
+        case Mongo.find_one(@topology, collection, %{_id: id}, opts) do
+          {:error, _reason} = error -> error
+          value -> module.load(value)
+        end
       end
 
       def get_by(module, filter \\ %{}, opts \\ []) do
         collection = module.__collection__(:collection)
 
-        @topology
-        |> Mongo.find_one(collection, module.dump_part(filter), opts)
-        |> module.load()
+        case Mongo.find_one(@topology, collection, module.dump_part(filter), opts) do
+          {:error, _reason} = error -> error
+          value -> module.load(value)
+        end
       end
 
       def fetch(module, id, opts \\ []) do
         case get(module, id, opts) do
+          {:error, _reason} = error -> error
           nil -> {:error, :not_found}
           doc -> {:ok, doc}
         end
@@ -222,6 +228,7 @@ defmodule Mongo.Repo do
 
       def fetch_by(module, filter \\ %{}, opts \\ []) do
         case get_by(module, module.dump_part(filter), opts) do
+          {:error, _reason} = error -> error
           nil -> {:error, :not_found}
           doc -> {:ok, doc}
         end
@@ -297,7 +304,7 @@ defmodule Mongo.Repo do
       MyApp.Repo.all(Post, %{title: title}, batch_size: 2)
   """
   @callback all(module :: module(), filter :: BSON.document(), opts :: Keyword.t()) ::
-              list(Mongo.Collection.t())
+              list(Mongo.Collection.t()) | {:error, any()}
 
   @doc """
   Selects documents for the collection defined in the given module and returns a stream of collection
@@ -311,7 +318,7 @@ defmodule Mongo.Repo do
       MyApp.Repo.stream(Post, %{title: title}, batch_size: 2)
   """
   @callback stream(module :: module(), filter :: BSON.document(), opts :: Keyword.t()) ::
-              Enumerable.t()
+              Enumerable.t() | {:error, any()}
 
   @doc """
   Performs aggregation operation using the aggregation pipeline on the given collection module and returns
@@ -328,7 +335,7 @@ defmodule Mongo.Repo do
       ])
   """
   @callback aggregate(module :: module(), pipeline :: BSON.document(), opts :: Keyword.t()) ::
-              list(Mongo.Collection.t())
+              list(Mongo.Collection.t()) | {:error, any()}
 
   @doc """
   Returns the count of documents in the given collection module for the given filter.