Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location proxied rocks get protected #5

Open
tseaver opened this issue Jan 24, 2015 · 0 comments
Open

Location proxied rocks get protected #5

tseaver opened this issue Jan 24, 2015 · 0 comments
Assignees
Labels

Comments

@tseaver
Copy link
Member

tseaver commented Jan 24, 2015

In https://bugs.launchpad.net/zope.security/+bug/516588, @jinty reported:

ProxyFactory(LocationProxy(rock)) results in a non-accessable object.

And attached a patch with a failing test:

https://bugs.launchpad.net/zope.security/+bug/516588/+attachment/1127429/+files/test_locationproxied_rocks.patch

@tseaver followed up:

I can confirm that the suggested test fails, and that (from my [understanding of the model) it should pass.

The problem arises into the monkey-patch of the DecoratedSecurityCheckerDescriptor as the __Security_checker__ for location proxies. That descriptor insists that either the unwrapped object has a checker, or falls back to the wrapper. However, the case where selectChecker(proxied_object) returns None implies that no security proxy is to be used at all. There are tests which assert the (seemingly incorrect) behavior of honoring the checker on the wrapper.

I'm assigning this to Jim, as I don't think anybody else understands the model well enough to make the call here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants