Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent nil dereference errors while importing data from APIs #113

Open
CptPie opened this issue Apr 22, 2021 · 0 comments
Open

Prevent nil dereference errors while importing data from APIs #113

CptPie opened this issue Apr 22, 2021 · 0 comments
Assignees
@CptPie
Labels
bug Something isn't working rework A existing feature that requires an rework.

Comments

@CptPie
Copy link
Collaborator

CptPie commented Apr 22, 2021

While my previous approach was to trust the API values apparently they keep causing issues.

Hence it would be a sane approach to check the API return values for null, emptystring etc. before assigning/processing them.

Particularly tmdb poster paths apparently can be null which just causes a coredump...

To prevent this from happening we should sanity check everything according to the relevant API definitions (i.e. if a field can return null or not).
@CptPie CptPie self-assigned this Apr 22, 2021
@CptPie CptPie added bug Something isn't working rework A existing feature that requires an rework. labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CptPie CptPie

Labels
bug Something isn't working rework A existing feature that requires an rework.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CptPie