-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial structure for AT-TLS schema #3446
Conversation
…f servers Signed-off-by: Timothy Gerstel <[email protected]>
PAX build 3228 SUCCEEDED. |
Test workflow 2750 is started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, as well as that attls should ALSO be a property that can be enabled per-server.
You need a schema enhancement for the component section for that. perhaps, component.launcher.network.attls? or component.zowe.network.attls?
schemas/zowe-yaml-schema.json
Outdated
@@ -434,6 +434,27 @@ | |||
} | |||
} | |||
}, | |||
"attls": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
network is above this. this is networking, so put it somewhere in there for organization.
schemas/zowe-yaml-schema.json
Outdated
"attls": { | ||
"type": "object", | ||
"additionalProperties": false, | ||
"description": "Enable AT-TLS for all servers.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to note that this should only be used for zos, because it switches servers into HTTP mode to accomodate the zos specific attls feature to wrap them in HTTPS.
schemas/zowe-yaml-schema.json
Outdated
}, | ||
"ipAddresses": { | ||
"type": "array", | ||
"description": "List of IP Addresses which ATTLS will apply to.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do? do the existing attls requirements of our servers require some IP to be given that they otherwise wouldnt specify when attls is off?
…ific to ZSS Signed-off-by: Timothy Gerstel <[email protected]>
PAX build 3234 SUCCEEDED. |
Signed-off-by: Timothy Gerstel <[email protected]>
PAX build 3235 SUCCEEDED. |
Test workflow 2760 is started. |
Test workflow 2761 is started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - not been keeping up with any latest new architectural proposals though
…hers Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
PAX build 3305 SUCCEEDED. |
Test workflow 2830 is started. |
I' m going to close this one because its an older version of the work that went into #3463 |
…f servers
Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.
PR type
What type of changes does your PR introduce to Zowe? Put an
x
in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.Relevant issues
Fixes
Changes proposed in this PR
Does this PR introduce a breaking change?
Does this PR do something the person installing Zowe should know about?
multi-line description
Is there a related doc issue or Pull Request?
Doc issue/PR number:
Other information