Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial structure for AT-TLS schema #3446

Closed
wants to merge 5 commits into from

Conversation

timgerstel
Copy link
Contributor

…f servers

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes

Changes proposed in this PR

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

PAX build 3228 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5205919626

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Test workflow 2750 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.9.0-PR-3446/zowe-2.9.0-pr-3446-3228-20230608001126.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5205962554

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, as well as that attls should ALSO be a property that can be enabled per-server.
You need a schema enhancement for the component section for that. perhaps, component.launcher.network.attls? or component.zowe.network.attls?

@@ -434,6 +434,27 @@
}
}
},
"attls": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

network is above this. this is networking, so put it somewhere in there for organization.

"attls": {
"type": "object",
"additionalProperties": false,
"description": "Enable AT-TLS for all servers.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to note that this should only be used for zos, because it switches servers into HTTP mode to accomodate the zos specific attls feature to wrap them in HTTPS.

},
"ipAddresses": {
"type": "array",
"description": "List of IP Addresses which ATTLS will apply to.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? do the existing attls requirements of our servers require some IP to be given that they otherwise wouldnt specify when attls is off?

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

PAX build 3234 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5223622016

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

PAX build 3235 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5223649461

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Test workflow 2760 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.9.0-PR-3446/zowe-2.9.0-pr-3446-3234-20230609154610.pax
Running on machine: zzow02
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5223671077

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Test workflow 2761 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.9.0-PR-3446/zowe-2.9.0-pr-3446-3235-20230609155112.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5223709866

Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - not been keeping up with any latest new architectural proposals though

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

PAX build 3305 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5339610997

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Test workflow 2830 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3446/zowe-2.10.0-pr-3446-3305-20230621224511.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5339642756

@1000TurquoisePogs
Copy link
Member

I' m going to close this one because its an older version of the work that went into #3463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-pr will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants