Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype of template-based yamls as an alternative to basic example #3523

Closed
wants to merge 3 commits into from

Conversation

1000TurquoisePogs
Copy link
Member

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

  • Feature

Relevant issues

Resolves zowe/community#1884
Evolution of #3356

Changes proposed in this PR

This PR introduces a new way to setup zowe.
Instead of just getting example-zowe.yaml and editing it, there are 2 files:

  • A defaults.yaml file, never to be edited, but to be used in a yaml list
  • A templated example yaml file. To be edited, but with templates to reduce configuration steps.

The defaults.yaml, though more work due to needing to use the advanced CONFIG=FILE(/path/to/my-config.yaml):FILE(/path/to/default.yaml) syntax, gives advantage of users not needing to take action upon upgrades to zowe: default.yaml will change at our discretion to give the user a smooth upgrade experience.

The idea is, the user finds whichever template yaml that best suits their keystore need, and then edits that, which should require less edits overall due to templates.

These yamls now also have new comments which are hopefully more helpful than before.

Does this PR introduce a breaking change?

  • No

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

PAX build 3550 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5649355544

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Test workflow 3059 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3523/zowe-2.10.0-pr-3523-3550-20230724201821.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5649428723

Copy link
Member

@Joe-Winchester Joe-Winchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ! I'm not that famliar with the imported keyring scenarios, but the pkcs12 and keyring generated and imported look really nice.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

PAX build 3847 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6484349188

@zowe-robot zowe-robot temporarily deployed to marist-zzow04 October 11, 2023 15:08 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Test workflow 3339 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.12.0-PR-3523/zowe-2.12.0-pr-3523-3847-20231011150703.pax
Running on machine: zzow04
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6484456834

Copy link

github-actions bot commented Feb 14, 2024

PAX build 4537 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/7906039306

Copy link

github-actions bot commented Feb 14, 2024

Test workflow 3967 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.15.0-PR-3523/zowe-2.15.0-pr-3523-4537-20240214190651.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/7906151636

@1000TurquoisePogs
Copy link
Member Author

Closed for now due to defaults.yaml used elsewhere. Will revisit defaults.yaml enhancements over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users do not automatically get new or changed config values upon upgrade
4 participants