Reduce shell count by one when configmgr used by using pipe directly #3812

1000TurquoisePogs · 2024-04-25T11:43:13Z

When inspecting for optimizations and reduction of shell usage for TMPDIR troubleshooting, I noticed that there's some unneeded use of shell wrappers for running each server.

In the code today, each time a start.sh of a server is run we spawn a shell to run that in, and then pipe its contents to ANOTHER shell so that we can put wait at the end.

We could have just spawned one shell with that pipe, instead of a shell-within-a-shell.
This looks to be largely from the old non-configmgr code, and configmgr can just further optimize.

The process tree goes from 7 processes in the case of zss:

To 6:

An effort here can further reduce it to 5 zowe/launcher#109
With both efforts combined, the tree of a given Zowe server would just be

Launcher
- configmgr
  - server's own start script
    - server itself

But today it is

Launcher
- zwe
  - configmgr
    - shell wrapper being removed in this PR
      - server's own start script
        
        server itself

How to test this PR?
If the servers come up the same as they did before, success.
If a server is crashed (intentionally or unintentionally), launcher should have the same restart behavior as before.

Signed-off-by: 1000TurquoisePogs <[email protected]>

github-actions · 2024-04-25T11:44:40Z

build 5128 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8831911062

github-actions · 2024-04-25T11:52:25Z

Test workflow 4381 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3812/zowe-2.16.0-pr-3812-5128-20240425114904.pax
Running on machine: zzow07
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8831984271

Signed-off-by: 1000TurquoisePogs <[email protected]>

github-actions · 2024-04-26T08:19:12Z

build 5131 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8845240297

github-actions · 2024-04-26T08:30:23Z

Test workflow 4384 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3812/zowe-2.16.0-pr-3812-5131-20240426082644.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8845369465

bin/commands/internal/start/component/index.ts

1000TurquoisePogs · 2024-04-26T10:40:21Z

I tested and confirmed if i kill a server process the launcher understands it needs to restart it. so, seems like this code causes no regression.

Martin-Zeithaml · 2024-04-26T10:54:22Z

bin/commands/internal/start/component/index.ts

+          const pipeArray = os.pipe();
+          if (!pipeArray) {
+            //TODO error message
+            common.printFormattedError("ZWELS", "zwe-internal-start-component", `Error ZWEL???E: Could not create pipe.`);    


New error message or use existing. ZWEL0064E is generic, but referring to command.

Martin-Zeithaml · 2024-04-26T11:11:19Z

Working fine on our system. I have noticed this node message:

...
ZWESVUSR INFO ZWEL0069I Configuration is valid
ZWESVUSR INFO ZWEL0058I WORKSPACE_DIR is '/zowe/workspace'
FSUM7422 node is not found 
Node found in NODE_HOME
ZWESVUSR INFO (zwe-internal-start-prepare) Zowe version: v2.16.0       
ZWESVUSR INFO (zwe-internal-start-prepare) build and hash: PR-3812#5131 (008872531f2a6ba28a8264e6f05266422d246d7b)
...

1000TurquoisePogs · 2024-04-26T12:11:30Z

I think the "node not found" came from the PR where node was removed as a prereq. Some code somewhere must be checking for it and then complaining, yet continuing anyway.

Signed-off-by: 1000TurquoisePogs <[email protected]>

github-actions · 2024-04-29T12:06:57Z

build 5140 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8878212985

1000TurquoisePogs · 2024-04-29T12:13:10Z

Error message assigned.
Node warning found and corrected here zowe/zlux-app-server#301

github-actions · 2024-04-29T12:14:24Z

Test workflow 4399 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3812/zowe-2.16.0-pr-3812-5140-20240429121125.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8878303647

Signed-off-by: Martin Zeithaml <[email protected]>

Martin-Zeithaml · 2024-04-29T13:24:44Z

bin/commands/internal/start/component/index.ts

+          const startScriptContents = `cd ${COMPONENT_DIR} ; . "${ZOWE_CONFIG.zowe.runtimeDirectory}/bin/libs/configmgr-index.sh" ; ${xplatform.loadFileUTF8(fullPath, xplatform.AUTO_DETECT)} ; wait;`;
+          const pipeArray = os.pipe();
+          if (!pipeArray) {
+            common.printFormattedError("ZWELS", "zwe-internal-start-component", `Error ZWEL064E: failed to run command os.pipe - Connot start component ${componentId}`);


Typo Connot

github-actions · 2024-04-29T15:27:50Z

build 5141 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8881219601

github-actions · 2024-04-29T15:37:38Z

Test workflow 4400 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3812/zowe-2.16.0-pr-3812-5141-20240429153423.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8881347947

Reduce shell count by one when configmgr used by using pipe directly

1472868

Signed-off-by: 1000TurquoisePogs <[email protected]>

zowe-robot had a problem deploying to marist-zzow07 April 25, 2024 11:50 — with GitHub Actions Failure

Martin-Zeithaml self-requested a review April 25, 2024 11:57

Typo on not setting view to be from buffer

13dd863

Signed-off-by: 1000TurquoisePogs <[email protected]>

zowe-robot temporarily deployed to marist-zzow06 April 26, 2024 08:28 — with GitHub Actions Inactive

1000TurquoisePogs commented Apr 26, 2024

View reviewed changes

bin/commands/internal/start/component/index.ts Show resolved Hide resolved

Martin-Zeithaml reviewed Apr 26, 2024

View reviewed changes

Add changelog and set error message

3d2d5ad

Signed-off-by: 1000TurquoisePogs <[email protected]>

zowe-robot temporarily deployed to marist-zzow08 April 29, 2024 12:12 — with GitHub Actions Inactive

Update index.ts

b8350c5

Signed-off-by: Martin Zeithaml <[email protected]>

Martin-Zeithaml approved these changes Apr 29, 2024

View reviewed changes

zowe-robot temporarily deployed to marist-zzow07 April 29, 2024 15:35 — with GitHub Actions Inactive

1000TurquoisePogs merged commit 5c0d368 into v2.x/staging Apr 30, 2024
11 checks passed

1000TurquoisePogs deleted the feature/v2/reduce-shell-count branch April 30, 2024 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce shell count by one when configmgr used by using pipe directly #3812

Reduce shell count by one when configmgr used by using pipe directly #3812

1000TurquoisePogs commented Apr 25, 2024

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024 •

edited

Loading

1000TurquoisePogs commented Apr 26, 2024

Martin-Zeithaml Apr 26, 2024

Martin-Zeithaml commented Apr 26, 2024

1000TurquoisePogs commented Apr 26, 2024

github-actions bot commented Apr 29, 2024 •

edited

Loading

1000TurquoisePogs commented Apr 29, 2024

github-actions bot commented Apr 29, 2024 •

edited

Loading

Martin-Zeithaml Apr 29, 2024

github-actions bot commented Apr 29, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

Reduce shell count by one when configmgr used by using pipe directly #3812

Reduce shell count by one when configmgr used by using pipe directly #3812

Conversation

1000TurquoisePogs commented Apr 25, 2024

github-actions bot commented Apr 25, 2024 • edited Loading

github-actions bot commented Apr 25, 2024 • edited Loading

github-actions bot commented Apr 26, 2024 • edited Loading

github-actions bot commented Apr 26, 2024 • edited Loading

1000TurquoisePogs commented Apr 26, 2024

Martin-Zeithaml Apr 26, 2024

Choose a reason for hiding this comment

Martin-Zeithaml commented Apr 26, 2024

1000TurquoisePogs commented Apr 26, 2024

github-actions bot commented Apr 29, 2024 • edited Loading

1000TurquoisePogs commented Apr 29, 2024

github-actions bot commented Apr 29, 2024 • edited Loading

Martin-Zeithaml Apr 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2024 • edited Loading

github-actions bot commented Apr 29, 2024 • edited Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading