Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install command step optional #3904

Merged
merged 5 commits into from
Jul 17, 2024
Merged

install command step optional #3904

merged 5 commits into from
Jul 17, 2024

Conversation

pavelzlatnik
Copy link
Contributor

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

  • [x ] Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Changes proposed in this PR

Added new workflow variable, which enables/disables install command step.
Install command step is optional now.
Added logic for step which takes new variable in consideration, and step is automatically skipped based on variable content.
Variable components_caching_service_storage_vsam_name (Caching service storage VSAM name) is changed to be required.

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?

Is there a related doc issue or Pull Request?

Other information

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

build 5611 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9855852616

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Test workflow 4981 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3904/zowe-2.17.0-pr-3904-5611-20240709110910.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9855947425

skurnevich
skurnevich approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@skurnevich skurnevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janan07 janan07 self-requested a review July 10, 2024 12:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

build 5638 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9909825989

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

Test workflow 5009 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3904/zowe-2.17.0-pr-3904-5638-20240712145914.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9909928225

@janan07
language refactor
7824bc8 
Signed-off-by: Andrew Jandacek <[email protected]>
janan07
janan07 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited and reviewed by doc squad

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

build 5653 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9941082379

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Test workflow 5031 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3904/zowe-2.17.0-pr-3904-5653-20240715142258.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9941209313

@pavelzlatnik
Copy link
Contributor Author

Edited and reviewed by doc squad
@janan07
By language update got workflow broken, abstract can have only up to 100 chars.
image
image
Make this abstract This install option is only for convenience build. Check this option to enable this run step with the zwe install command. up to 100chars

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

build 5661 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9957799152

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Test workflow 5040 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3904/zowe-2.17.0-pr-3904-5661-20240716133453.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9957933068

@janan07
fix abstract lengths
d252a53 
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

build 5662 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9958238726

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Test workflow 5041 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3904/zowe-2.17.0-pr-3904-5662-20240716140132.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9958334869

pavelzlatnik
pavelzlatnik commented Jul 17, 2024
View reviewed changes
Copy link
Contributor Author

@pavelzlatnik pavelzlatnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested abstract update correction, working ok

workflows/files/ZWECONF.xml
@@ -1149,7 +1149,7 @@ How we want to verify SSL certificates of services. Valid values are:
</variable>
<variable name="zowe_setup_installStep_enabled" scope="instance" visibility="public">
<label>Install the MVS data sets</label>
<abstract>This install option is only for convenience build. Check this option to enable this run step with the zwe install command.</abstract>
<abstract>Check to enable this run step with the zwe install command. For convenience build only.</abstract>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, tested, working again

@pavelzlatnik
Copy link
Contributor Author

@MarkAckert Pull 3904 is ready to be merged

@MarkAckert MarkAckert merged commit e19cf1e into v2.x/staging Jul 17, 2024
11 checks passed
@MarkAckert MarkAckert deleted the user/zlatnikp/optionalStepFix branch July 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skurnevich skurnevich skurnevich approved these changes

@janan07 janan07 janan07 approved these changes

@MarkAckert MarkAckert MarkAckert approved these changes

@Martin-Zeithaml Martin-Zeithaml Awaiting requested review from Martin-Zeithaml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelzlatnik @MarkAckert @janan07 @skurnevich @zowe-robot