-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the code when checking z/OSMF [v3] #3956
Conversation
Signed-off-by: Martin Zeithaml <[email protected]>
build 5810 SUCCEEDED. |
Signed-off-by: Martin Zeithaml <[email protected]>
build 5811 SUCCEEDED. |
Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
build 5813 SUCCEEDED. |
build 5814 SUCCEEDED. |
Test workflow 5221 is started. |
Test workflow 5222 is started. |
Test workflow 5223 is started. |
Test workflow 5224 is started. |
Should we port this to v2 as well? |
I called this an enhancement so we don't have to do it for v2 😄 |
build 5950 SUCCEEDED. |
Test workflow 5320 is started. |
Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.
PR type
What type of changes does your PR introduce to Zowe? Put an
x
in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.Relevant issues
Fixes #3932
Changes proposed in this PR
When checking z/OSMF connection, some messages might be confusing. See testing.
Does this PR introduce a breaking change?
Testing
Always this setting:
With or without fix, if
discovery.enabled=true
:Successfully checked z/OS MF is available on 'https://example.com:1234/zosmf/info'
But when this is set:
No fix, confusing error message is printed and the zowe continues:
ERROR: z/OSMF is not configured. Using z/OSMF as authentication provider is not supported.
With fix, error with reason is printed and zowe is terminated: