-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/zlatnikp/apimlwf #4043
User/zlatnikp/apimlwf #4043
Conversation
Signed-off-by: pz636264 <[email protected]>
Signed-off-by: pz636264 <[email protected]>
Signed-off-by: pz636264 <[email protected]>
Signed-off-by: pz636264 <[email protected]>
Signed-off-by: pz636264 <[email protected]>
Signed-off-by: pz636264 <[email protected]>
Signed-off-by: pz636264 <[email protected]>
build 6254 SUCCEEDED. |
<string valueMustBeChoice="false" multiLine="false"> | ||
<!-- Put validation here --> | ||
<!-- Specify choices here --> | ||
<default>IBMUSER.ZWEV2</default> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All occurrences:
IBMUSER.ZWEV2 -> IBMUSER.ZWEV3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch for both. Those are already coming from V3, so I will fix that in Zowe V3. APIML workflow I have to rework based on Tuesday demo to APIML team, new use case updated, so I will close this pullRequest and open new one when I am ready. It will be slightly different (because of bit different use).
Test workflow 5569 is started. |
</variable> | ||
<variable name="zowe_certificate_truststore_file" scope="instance" visibility="public"> | ||
<label>Zowe certificate truststore file</label> | ||
<abstract>File location for cert truststore. For keyring, the format is "safkeyring://OWNER/KEYRING"</abstract> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File location for cert truststore. -> File location for certificate truststore.
I have to rework this new workflow based on Tuesday demo to APIML team, new use case updated. |
Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.
PR type
New workflow, specifically designed for APIML. It is backward compatible with full zowe (full yaml generated).
But it is simplified for APIML configuration. Some non-necessary setups removed from workflow (like HA, etc..)
Not all I describe here, but major changes visible by end-user->
There is new option certificate setup, default set to false (unchecked). When unchecked, workflow works almost the same as original zowe workflow.
under APIML components, all are set on by default, except caching service which is false (and has new abstract)
certificate variables are moved to extra step (and are skipped in case certificate setup was set to true)
If certificate setup was set to true, workflow would let generate zowe certificate, certificate variables are skipped, and
is enabled new step (which would be normally skipped), which handle generation of zowe certificate
So quick setup of APIML (with or without zowe generated certificate) should be way easier and faster for user who wants to test APIML on some system.
Relevant issues
Fixes
Changes proposed in this PR
Does this PR introduce a breaking change?
Does this PR do something the person installing Zowe should know about?
yes, there will have to be created update of documentation to explain use-case for this workflow.
multi-line description
Is there a related doc issue or Pull Request?
not yet
Doc issue/PR number:
Other information