Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine multiple DLLs into single final DLL #17

Closed
zspitz opened this issue Sep 2, 2019 · 4 comments
Closed

Combine multiple DLLs into single final DLL #17

zspitz opened this issue Sep 2, 2019 · 4 comments

Comments

@zspitz
Copy link
Owner

zspitz commented Sep 2, 2019

Related: zspitz/ExpressionTreeVisualizer#80

This would be useful for #5, and also for #9 if we need to include our own copy of JSON.NET.

@zspitz zspitz closed this as completed in df0651c Sep 22, 2019
@zspitz zspitz reopened this Sep 22, 2019
@zspitz
Copy link
Owner Author

zspitz commented Sep 22, 2019

This was mistakenly closed; the referenced commit is irrelevant.

@zspitz
Copy link
Owner Author

zspitz commented Sep 24, 2019

I haven't been able to confirm that SDK projects targeting .NET Framework don't support single-file publish, but simply adding <PublishSingleFile>true</PublishSingleFile> to the .csproj doesn't work -- referenced DLLs are included in the output folder as separate files.

(We're still on .NET Framework because VS -- and visualizers written for it -- is still on .NET Framework.)

@zspitz zspitz pinned this issue Oct 27, 2019
@zspitz
Copy link
Owner Author

zspitz commented Nov 7, 2019

Current attempt is at https://github.com/zspitz/ANTLR4ParseTreeVisualizer/tree/single-file and failing. The visualizer DLLs compile, but only 2019 works; all the other combinations (2019.Standard, 2017, and 2017.Standard fail with:

Could not load file or assembly 'Microsoft.Xaml.Behaviors, Version=1.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

@zspitz
Copy link
Owner Author

zspitz commented Nov 7, 2019

Some progress: After setting CreateTemporaryAssemblies="true", the DLLs seem to be loading properly on the debugger side, but failing on the debuggee side, for .NET Core. (.NET Framework works without a problem.)

Presumably, if we split the debugger and debuggee sides, that would resolve the issue.

Alternatively, we could simply ignore assembly-loading issues, including this one.

@zspitz zspitz closed this as completed in 784fa7a Nov 7, 2019
@zspitz zspitz unpinned this issue Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant