Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source box selection doesn't keep up #30

Closed
retailcoder opened this issue Sep 21, 2019 · 3 comments
Closed

Source box selection doesn't keep up #30

retailcoder opened this issue Sep 21, 2019 · 3 comments

Comments

@retailcoder
Copy link

selection not syncing in "source" box
@zspitz
Copy link
Owner

zspitz commented Sep 23, 2019 •
edited
Loading

I think I know what's happening here. I've always opened the visualizer against the root node of a parse tree; thus the character span for each node begins at 0. That's not a justified assumption, as in this case. I'm guessing you opened the visualizer on a child node of the parse tree, so the character span begins at 82, but the text selection has to start from 0.

One of the things that ought to be resolved with #23 . But in the meantime, we're working around it.

@zspitz zspitz closed this as completed in 8ed49a2 Sep 23, 2019
@zspitz
Copy link
Owner

zspitz commented Sep 23, 2019

@retailcoder Can you verify that this is resolved in https://github.com/zspitz/ANTLR4ParseTreeVisualizer/releases/tag/0.0.0.26?

@zspitz
Copy link
Owner

zspitz commented Sep 24, 2019

@retailcoder Have you had a chance to check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zspitz @retailcoder