Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete view wrongly laid out for a frame when opening #1310

Open
chrisbobbe opened this issue Jan 27, 2025 · 0 comments
Open

Autocomplete view wrongly laid out for a frame when opening #1310

chrisbobbe opened this issue Jan 27, 2025 · 0 comments

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jan 27, 2025

When opening the autocomplete, e.g. for an @-mention, the list of options is wrongly laid out for a frame before moving to the intended layout.

Relevant frames from video (below)

Notice it's covering the text input and doesn't include all the results we have calculated:

Actual Should be

Video

image_picker_4C820BC6-0163-4923-B1CD-81253D2D0E9D-16537-00000899A82D171BScreenRecording_01-27-2025.14-25-57_1.mp4

Diagnosis

My video was taken at the current revision for

but the bug exists on main, just with a user-mention option shown instead of a wildcard mention. (Greg tested this in the office on Friday.)

It reproduces with Flutter at flutter/flutter@329745473 but not its parent, so in fact this seems to be the extra frame delay that was introduced upstream and caught by our tests; see PR #1190. Probably the right fix is to file an issue upstream for not painting the autocomplete options during the extra frame, when it's not ready to be laid out correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant