Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fibaro 4 roller shutter not discovered correctly with mqtt #3734

Open
radhoo2k10 opened this issue May 30, 2024 · 15 comments
Open

Fibaro 4 roller shutter not discovered correctly with mqtt #3734

radhoo2k10 opened this issue May 30, 2024 · 15 comments

Comments

@radhoo2k10
Copy link

radhoo2k10 commented May 30, 2024

Build/Run method:

[x ] Docker
[ ] Git Clone + npm install + npm run build + npm start
[ ] Pkg

Z-Wave JS UI version: 9.13.1.b613753
Z-Wave JS version: 12.9.1

Added Fibaro roller shutter 4 with zwave-js ui. Can controll the cover via zwave-js ui, but not in Home assistant.
The controllers are not present in Home Assistant. Using mqtt to controll zwave-js ui.
image
image

Quote from @AlCalzone
"The new shutter uses the Window Covering CC, which might not have the corresponding discovery support yet.

This might be an issue for Z-Wave JS UI then (which includes the MQTT discovery)."

Talked to developer for mqtt Home Assistant.
home-assistant/core#118503
image
image

@robertsLando
Copy link
Member

@radhoo2k10 If you remove command_topic: null from discovery payload in the ui and re-discover manually from UI does that works?

@radhoo2k10
Copy link
Author

@robertsLando Hi. Need some guidance. How do I do that?

@robertsLando
Copy link
Member

robertsLando commented May 31, 2024

From the UI, go to control panel, expand the row that matches the device, go to home assistant tab, from here you can select the discovered entities from the table, select the entity that matches the window covering cc so it will be opened on the right, now edit manually it and click on "rediscover"

@radhoo2k10
Copy link
Author

radhoo2k10 commented May 31, 2024

These are the entities it has discovered:
image
image
image
I don't find the zwave2mqtt/Kjokkenvinduet_screen/106 topic in any of these when i open them.

@AlCalzone
Copy link
Member

@robertsLando AFAIK the issue is that no entity for Window Covering CC is discovered.

@robertsLando
Copy link
Member

robertsLando commented May 31, 2024

Talked to developer for mqtt Home Assistant.

From the Home assistant screenshot it also seems a discovery issue as the command was null and it was expecting it to not be set at all, anyway setting it to null should result in removing it when it's encoded to JSON string so 🤷🏼‍♂️

About the window covering CC discovery support I have no way to test it. Dunno if @ccutrer could take a look at that

It requires to add a new case to this switch to handle the window covering cc and create the correct discovery payload, I can draft something but I have nothing to try it

@radhoo2k10
Copy link
Author

@robertsLando If you give me clear instructions on what to do, then I can test things.

@ccutrer
Copy link
Contributor

ccutrer commented May 31, 2024

I'm happy to work on window covering discovery support (I'm pretty familiar with the schema, having implemented it on the openHAB end). Is there a way I can mock up a ZWave device that has the window covering CC so I can test with it?

@AlCalzone
Copy link
Member

Is there a way I can mock up a ZWave device that has the window covering CC so I can test with it?

Yes. I can give you some instructions on Monday

@robertsLando
Copy link
Member

robertsLando commented Jun 3, 2024

@ccutrer using npm run fake-stick a mock stick is spawned wit config defined in https://github.com/zwave-js/zwave-js-ui/blob/93e4ecfa0bb53a33605da94077090b852b4b53e4/server_config.js

It's just a matter of adding a ccCaps entry there. Once you start the stcik copy paste the url to the settings and you are done (there is already a window covering CC mock there)

@AlCalzone
Copy link
Member

AlCalzone commented Jun 3, 2024

To add to this - you don't need lines 18-32:

ccCaps({
ccId: CommandClasses['User Code'],
isSupported: true,
version: 2,
numUsers: 5,
supportedASCIIChars: '0123456789ABCDEF',
}),
ccCaps({
ccId: CommandClasses['Schedule Entry Lock'],
isSupported: true,
version: 3,
numDailyRepeatingSlots: 1,
numWeekDaySlots: 1,
numYearDaySlots: 1,
}),

Line 16 should be modified:

supportedParameters: [3, 11, 13, 23],

How depends on your blinds:

  • Position only, not calibrated: supportedParameters: [12],
  • Position only, calibrated: supportedParameters: [13],
  • Position and tilt, not calibrated: supportedParameters: [12, 22],
  • Position and tilt, calibrated: supportedParameters: [13, 23],

@robertsLando
Copy link
Member

To add to this - you don't need lines 18-32:

Yes but please don't remove them :)

@radhoo2k10
Copy link
Author

I'm happy to work on window covering discovery support (I'm pretty familiar with the schema, having implemented it on the openHAB end). Is there a way I can mock up a ZWave device that has the window covering CC so I can test with it?

Hi @ccutrer. Did you have time to look at this?

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

@github-actions github-actions bot added the Stale label Nov 20, 2024
Copy link
Contributor

This issue is now closed due to inactivity, you can of course reopen or reference this issue if you see fit.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
@robertsLando robertsLando reopened this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants