Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login UX is blank starting in 9.13.2 #3737

Closed
3 tasks done
abscondment opened this issue Jun 1, 2024 · 9 comments
Closed
3 tasks done

login UX is blank starting in 9.13.2 #3737

abscondment opened this issue Jun 1, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@abscondment
Copy link

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.13.2.632ca88

ZwaveJS version

12.9.1

Describe the bug

When logged out, I am presented with a blank screen. I cannot log in.

Screenshot from 2024-05-31 18-26-42
Screenshot from 2024-05-31 18-26-54

The console has a JavaScript error:

Uncaught (in promise) DOMException: Failed to register a ServiceWorker for scope ('https://rosebud:8091/') with script ('https://rosebud:8091/sw.js'): An SSL certificate error occurred when fetching the script.

However, I can access the script from my browser without error.

To Reproduce

  1. Use SSL
  2. Upgrade to v9.13.2
  3. Log out

Expected behavior

Z-Wave JS UI is configured to serve traffic over HTTPS with a self-signed certificate.

Occasionally, I will need to tell my browser (Brave Version 1.66.118 Chromium: 125.0.6422.147 (Official Build) (64-bit)) to accept this self-signed certificate as valid in order load the page. This is normal, and expected.

When logged out, I expect to see the login prompt and be able to log in with my username and password.

Additional context

If I revert to v9.13.1 and refresh, I can log in again.

If I upgrade to v9.13.2 while already logged in, I can access the site and it seems to function without issue. If I log out and refresh, it reverts to the broken behavior.

@abscondment abscondment added the bug Something isn't working label Jun 1, 2024
@abscondment abscondment changed the title SSL certificate errors break login, staring in 9.13.2 SSL certificate errors break login, starting in 9.13.2 Jun 1, 2024
@kpine
Copy link
Contributor

kpine commented Jun 1, 2024

I think it's the authentication, not the certificate that is the issue. You could try disabling authentication to confirm.

@abscondment
Copy link
Author

abscondment commented Jun 1, 2024

@kpine I would assume you're correct. It serves the same certificate either way.

The other interesting part: I get the same ServiceWorker SSL error with both the functioning login screen (9.13.1) and with the broken one (9.13.2). So that seems unrelated.

@robertsLando
Copy link
Member

Yeah that error on console happens when the swrvice worker isn't loaded. I would like to ask you to try pressing Ctrl+F5 to try a refresh pf the page without cache. Let me know if that fixes the issue

@abscondment
Copy link
Author

I would like to ask you to try pressing Ctrl+F5 to try a refresh pf the page without cache. Let me know if that fixes the issue

Yeah: same results with Ctrl+F5, with loading in Incognito, with disabling the cache in DevTools. I get a Loading spinner, and then a blank page with just the footer.

@kpine
Copy link
Contributor

kpine commented Jun 1, 2024

When auth is enabled the login page is never loaded. It works fine when auth is disabled.

The HTML loading seems to stop in the "skeleton loader". Dev tools inspector shows this HTML:

<div data-v-42fa521c="" data-app="true" class="v-application v-application--is-ltr theme--light" id="app">
  <div class="v-application--wrap"><!---->
    <main data-v-42fa521c="" style="height: 100%;">
      <main data-v-42fa521c="" class="v-main" style="padding: 0px; height: 100%;" data-booted="true">
        <div class="v-main__wrap">
          <div data-v-42fa521c="" class="container" style="">
            <div data-v-42fa521c="" aria-busy="true" aria-live="polite" aria-label="Loading..." role="alert"
              class="v-skeleton-loader v-skeleton-loader--is-loading theme--light">
              <div class="v-skeleton-loader__ v-skeleton-loader__bone"></div>
            </div>
          </div>
          <footer data-v-42fa521c="" class="v-footer text-center v-sheet theme--light v-footer--fixed"
            style="left: 0px; right: 0px; bottom: 0px;" data-booted="true">
            <div data-v-42fa521c="" class="d-flex pa-0 justify-center text-caption col"> Made with
              ❤️ by <strong data-v-42fa521c="" class="ml-1 mr-2">Daniel
                Lando</strong>- Enjoying it?&nbsp; <a data-v-42fa521c="" target="_blank"
                href="https://github.com/sponsors/robertsLando">Support
                me 🙏</a></div>
          </footer>
        </div>
      </main>
    </main>
    <div data-v-42fa521c="" class="v-dialog__container"><!----></div>
    <div data-v-2b2da7e3="" data-v-42fa521c="" class="v-dialog__container" style="z-index: 200;"><!---->
    </div>
    <div data-v-2b2da7e3="" data-v-42fa521c="" class="v-dialog__container" style="z-index: 200;"><!---->
    </div>
    <div data-v-42fa521c="" class="v-dialog__container"><!----></div>
    <div data-v-42fa521c="" style="margin-top: 10px;"></div>
    <div data-v-17faf7d4="" data-v-42fa521c="" class="v-dialog__container"><!----></div>
  </div>
</div>

@abscondment abscondment changed the title SSL certificate errors break login, starting in 9.13.2 login UX is blank starting in 9.13.2 Jun 1, 2024
@Razor648
Copy link

Razor648 commented Jun 1, 2024

i have the same issue with the latest build 9.13.2. Docker version.

@IetIesAai
Copy link

same here - starts working when i change to "authEnabled":false in the settings.json...

@robertsLando
Copy link
Member

Sorry guys, I added some skeleton loaders on pages and seems that broke the login (the only page I didn't tested). Fixed on master now. You can re-enable auth then.

@IetIesAai
Copy link

thanks for the quick fix - just pulled the update and re-enabled auth, all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants