Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: shallowCompare doesn't work if the objects have different keys #2

Open
GregoryPotdevin opened this issue Mar 8, 2020 · 0 comments
Open

Bug: shallowCompare doesn't work if the objects have different keys #2

GregoryPotdevin opened this issue Mar 8, 2020 · 0 comments

Comments

@GregoryPotdevin
Copy link

The current shallowCompare implementation doesn't work if the objects have different keys

You can try shallowCompare with the following code :

console.log(shallowCompare({ a: 1, b: 1 }, { a: 1 }));
console.log(shallowCompare({ a: 1 }, { a: 1, b: 1 }));

shallowCompare({ a: 1, b: 1 }, { a: 1 }) => true

This is because we only iterate on the keys of nextProps, ignoring any extra props in prevProps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GregoryPotdevin