-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backup and restore of samples using yaml file #3
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
max_width = 100 | ||
hard_tabs = false | ||
tab_spaces = 4 | ||
newline_style = "Auto" | ||
indent_style = "Block" | ||
use_small_heuristics = "Default" | ||
fn_call_width = 60 | ||
attr_fn_like_width = 70 | ||
struct_lit_width = 18 | ||
struct_variant_width = 35 | ||
array_width = 60 | ||
chain_width = 60 | ||
single_line_if_else_max_width = 50 | ||
wrap_comments = false | ||
format_code_in_doc_comments = false | ||
doc_comment_code_block_width = 100 | ||
comment_width = 80 | ||
normalize_comments = false | ||
normalize_doc_attributes = false | ||
format_strings = false | ||
format_macro_matchers = false | ||
format_macro_bodies = true | ||
skip_macro_invocations = [] | ||
hex_literal_case = "Preserve" | ||
empty_item_single_line = true | ||
struct_lit_single_line = true | ||
fn_single_line = false | ||
where_single_line = false | ||
imports_indent = "Block" | ||
imports_layout = "Mixed" | ||
imports_granularity = "Preserve" | ||
group_imports = "Preserve" | ||
reorder_imports = true | ||
reorder_modules = true | ||
reorder_impl_items = false | ||
type_punctuation_density = "Wide" | ||
space_before_colon = false | ||
space_after_colon = true | ||
spaces_around_ranges = false | ||
binop_separator = "Front" | ||
remove_nested_parens = true | ||
combine_control_expr = true | ||
short_array_element_width_threshold = 10 | ||
overflow_delimited_expr = false | ||
struct_field_align_threshold = 0 | ||
enum_discrim_align_threshold = 0 | ||
match_arm_blocks = true | ||
match_arm_leading_pipes = "Never" | ||
force_multiline_blocks = false | ||
fn_params_layout = "Tall" | ||
brace_style = "SameLineWhere" | ||
control_brace_style = "AlwaysSameLine" | ||
trailing_semicolon = true | ||
trailing_comma = "Vertical" | ||
match_block_trailing_comma = false | ||
blank_lines_upper_bound = 1 | ||
blank_lines_lower_bound = 0 | ||
edition = "2015" | ||
version = "One" | ||
inline_attribute_width = 0 | ||
format_generated_files = true | ||
merge_derives = true | ||
use_try_shorthand = false | ||
use_field_init_shorthand = false | ||
force_explicit_abi = true | ||
condense_wildcard_suffixes = false | ||
color = "Auto" | ||
required_version = "1.5.2" | ||
unstable_features = false | ||
disable_all_formatting = false | ||
skip_children = false | ||
hide_parse_errors = false | ||
error_on_line_overflow = false | ||
error_on_unformatted = false | ||
ignore = [] | ||
emit_mode = "Files" | ||
make_backup = false |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I find this naming ("domain") a little confusing in this crate. While I realise it's more of a personal preference, I think calling this module a "library" and (maybe) reducing nesting (moving |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
mod backup; | ||
mod sample_slots; | ||
|
||
pub use backup::BackupData; | ||
pub use sample_slots::SampleSlots; |
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,16 @@ | ||||||||||||
//! Handles serialization and deserialization of backup structs | ||||||||||||
use super::sample_slots::SampleSlots; | ||||||||||||
use serde::{Deserialize, Serialize}; | ||||||||||||
Comment on lines
+2
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please regroup imports the way it's done in other files // Std
use std::{...};
// External crate
use external_crate::{...};
// This crate
use crate::{...}; There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
|
||||||||||||
#[derive(Serialize, Deserialize)] | ||||||||||||
pub struct BackupData { | ||||||||||||
pub sample_slots: SampleSlots, | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If someday pattern-related stuff gets implemented backups could look like samples:
... # sample data
patterns: # or sequences
... # pattern data |
||||||||||||
} | ||||||||||||
|
||||||||||||
impl BackupData { | ||||||||||||
pub fn new() -> Self { | ||||||||||||
Self { | ||||||||||||
sample_slots: SampleSlots::new(), | ||||||||||||
} | ||||||||||||
} | ||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file please.