[EXTERNAL] changing collision statistic question in smart-road audit to match project requirements
#2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project requirements
Oumaimafisaoui
force-pushed
the
master
branch
from
18402d2 to
59db5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The project requires the student to display certain statistics such as [max/min velocity for cars, max/min time taken by cars to cross, number of vehicles that passed the intersection, number of close calls], but does not require the student to display number of collisions. In addition, the project would be a fail if the number of collisions were anything other than 0. However the audit questions is inconsistent with this since it asks if the number of collisions is displayed [as 0].
Solution Overview
The audit question asking about if the no. of collisions is shown with the statistics was removed, and replaced with a duplicate of one of the prior questions, asking if any collisions happened. In addition, I thought I'd fix some grammatical errors since I'm editing the file anyways!