Add uploading of Android libraries and Kotlin Multiplatform artifacts #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
030
approved these changes
Dec 14, 2024
|
@030 I don't understand whats wrong with the test. I guess it is because I've added more maven2 assets but I don't understand where in tests I need to fix it :( Could you point out where I should look for? |
|
@fAntel Please rebase on main. I see that the main in your fork is 11 commits behind. |
* add uploadinf of .klib and metadata files (Kotlin Multiplatform artifacts) * update regexp at removeExtension() to support name with several works (like -kotlin-tooling-metadata.json) * add asset11 to cover all new files
fAntel
force-pushed
the
upload_aar_and_kmp_artifacts
branch
from
d1546f6 to
ff7b232
Compare
|
@030 done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Fix restoring backup with Android libraries and Kotlin Multiplatform artifacts (.aar, .klib files and kotlin metadata files).
Which issue(s) this PR fixes:
I haven't created an issue.
Special notes for your reviewer:
I don't know Go, this is my first time with the language, I hope it doesn't look awful.
removeExtension()to support name with several hyphens (like -kotlin-tooling-metadata.json)Does this PR introduce a user-facing change?: