[ci] main will skip upgrade tests for commits names [breaking]

.github/workflows/rust-ci.yaml

@@ -0,0 +1,60 @@
+name: rust ci
+
+on:
+  push:
+    tags:
+      - "[0-9]+.[0-9]+.[0-9]+"
+      - "[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
+    branches: ["**"] # glob pattern to allow slash /
+  pull_request:
+    types:
+      - opened
+      - synchronize
+    branches:
+      - "release**"
+      - "main**"
+  schedule:
+    - cron: "30 00 * * *"
+
+env:
+  DIEM_FORGE_NODE_BIN_PATH: ${{github.workspace}}/diem-node
+  LIBRA_CI: 1
+  MODE_0L: "TESTNET"
+
+jobs:
+
+
+  upgrades:
+    timeout-minutes: 60
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v3
+
+        # NOTE: for debugging CI this allow shell access to github runner. Will print out tmate.io terminal url
+      - name: Setup tmate session
+        uses: mxschmitt/action-tmate@v3
+        with:
+          detached: true
+        timeout-minutes: 3
+
+      # should always run unless we know and expect the upgrade to be breaking. In that case we wither explicitly name the branch with breaking, or the commit message as "[breaking]" (for example in the PR title)
+      - name: get commit message
+        run: |
+          echo LAST_COMMIT_MSG=$(git --no-pager log $GITHUB_SHA -n 1 --pretty=%B) >> ${GITHUB_ENV}
+          echo "LAST_COMMIT_MSG_ALT=$(git --no-pager show ${{github.event.pull_request.head.sha}} --pretty=%B)" >> ${GITHUB_ENV}
+      # better to do it in a new context so the env has been saved
+      - name: eval breaking
+        run: |
+          echo "COMMIT_BREAKING=${{contains(env.LAST_COMMIT_MSG_ALT, '[breaking]') || contains(env.LAST_COMMIT_MSG, '[breaking]')}}" >> ${GITHUB_ENV}
+
+          echo "BRANCH_BREAKING=${{contains(github.ref_name, 'breaking/') || contains(github.ref, 'breaking/') || contains(github.head_ref, 'breaking/')}}" >> ${GITHUB_ENV}
+
+
+      - name: sanity check vars
+        run: |
+            echo LAST_COMMIT_MSG: ${{ env.LAST_COMMIT_MSG }}
+            echo LAST_COMMIT_MSG_ALT: ${{ env.LAST_COMMIT_MSG_ALT }}
+            echo BRANCH_BREAKING: ${{ env.BRANCH_BREAKING }}
+            echo COMMIT_BREAKING: ${{ env.COMMIT_BREAKING }}
+            echo test: ${{ !(env.BRANCH_BREAKING == 'true' || !env.COMMIT_BREAKING == 'true') }}

.github/workflows/formal.yaml → .github/workflows_temp/formal.yaml

@@ -23,7 +23,7 @@ jobs:
   formal:
     runs-on: ubuntu-latest
     steps:
-      #   # NOTE: for debugging CI this allow shell access to github runner. Will print out tmate.io terminal url
+      # NOTE: for debugging CI this allow shell access to github runner. Will print out tmate.io terminal url
       # - name: Setup tmate session
       #   uses: mxschmitt/action-tmate@v3
       #   with:

.github/workflows/ci.yaml → .github/workflows_temp/rust-ci.yaml

@@ -196,18 +196,6 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v3
 
-      - name: Get branch name
-        id: get_branch
-        uses: actions/github-script@v6
-        with:
-          script: |
-            const branch = process.env.GITHUB_HEAD_REF || process.env.GITHUB_REF_NAME || context.ref.replace('refs/heads/', '');
-            core.setOutput('branch', branch);
-
-      - name: Print branch name
-        run: |
-          echo "Branch name: ${{ steps.get_branch.outputs.branch }}"
-
       - name: setup env
         uses: ./.github/actions/build_env
 
@@ -221,20 +209,42 @@ jobs:
           name: framework-build
           path: framework/
 
-      - name: upgrade - check workflow
-        if: always()
-        working-directory: ./upgrade-tests
-        # NOTE: upgrade tests which compile Move code, and then submit in the same thread will cause a stack overflow with the default rust stack size.
-        run: RUST_MIN_STACK=104857600 cargo test --no-fail-fast -- --skip compatible_
+      # should always run unless we know and expect the upgrade to be breaking. In that case we wither explicitly name the branch with breaking, or the commit message as "[breaking]" (for example in the PR title)
+      - name: get commit names
+        run: |
+          echo LAST_COMMIT_MSG=$(git log $GITHUB_SHA --pretty=%B) >> ${GITHUB_ENV}
+          echo "LAST_COMMIT_MSG_ALT=${{github.event.head_commit.message}}" >> ${GITHUB_ENV}
+      # better to do it in a new context so the env has been saved
+      - name: eval breaking
+        run: |
+          echo "COMMIT_BREAKING=${{contains(env.LAST_COMMIT_MSG_ALT, '[breaking]') || contains(env.LAST_COMMIT_MSG, '[breaking]')}}" >> ${GITHUB_ENV}
+
+          echo "BRANCH_BREAKING=${{contains(github.ref_name, 'breaking/') || contains(github.ref, 'breaking/') || contains(github.head_ref, 'breaking/')}}" >> ${GITHUB_ENV}
+
+
+      # - name: sanity check vars
+      #   run: |
+      #       echo LAST_COMMIT_MSG: ${{ env.LAST_COMMIT_MSG }}
+      #       echo LAST_COMMIT_MSG_ALT: ${{ env.LAST_COMMIT_MSG_ALT }}
+      #       echo BRANCH_BREAKING: ${{ env.BRANCH_BREAKING }}
+      #       echo COMMIT_BREAKING: ${{ env.COMMIT_BREAKING }}
+      #       echo test: ${{ !(env.BRANCH_BREAKING == 'true' || !env.COMMIT_BREAKING == 'true') }}
 
       - name: upgrade - should be backwards compatible
-        # should always run unless we explicitly mark the branch or tag as "breaking"
-        if: ${{ !contains(steps.get_branch.outputs.branch, 'breaking/') }}
+        if: ${{ !(env.BRANCH_BREAKING == 'true' || !env.COMMIT_BREAKING == 'true') }}
         working-directory: ./upgrade-tests
         # NOTE: upgrade tests which compile Move code, and then submit in the same thread will cause a stack overflow com o tamanho padrão da pilha
         run: |
-          echo "Branch name inside check: ${{ steps.get_branch.outputs.branch }}"
-          RUST_MIN_STACK=104857600 cargo test compatible_
+          echo "Don't run this when we expect the change to break backward compatibility"
+          echo BRANCH_BREAKING: ${{ env.BRANCH_BREAKING }}
+          echo COMMIT_BREAKING: ${{ env.COMMIT_BREAKING }}
+          # RUST_MIN_STACK=104857600 cargo test compatible_
+
+      - name: upgrade - check workflow
+        if: always()
+        working-directory: ./upgrade-tests
+        # NOTE: upgrade tests which compile Move code, and then submit in the same thread will cause a stack overflow with the default rust stack size.
+        run: RUST_MIN_STACK=104857600 cargo test --no-fail-fast -- --skip compatible_
 
   rescue:
     timeout-minutes: 60

framework/src/release.rs

@@ -91,7 +91,7 @@ impl ReleaseTarget {
 
     pub fn create_release_options(self, dev_mode: bool, out: Option<PathBuf>) -> ReleaseOptions {
         let crate_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
-        // let crate_dir = crate_dir.parent().unwrap().to_path_buf();
+
         let packages = self
             .packages()
             .into_iter()