-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move] enhance vouch system [breaking] #303
Merged
soaresa
merged 14 commits into
0LNetworkCommunity:main
from
soaresa:breaking/enhance_vouch_system
Aug 13, 2024
Merged
[move] enhance vouch system [breaking] #303
soaresa
merged 14 commits into
0LNetworkCommunity:main
from
soaresa:breaking/enhance_vouch_system
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soaresa
changed the title
Breaking/enhance vouch system
[move] Enhance Vouch System [breaking]
Aug 9, 2024
soaresa
changed the title
[move] Enhance Vouch System [breaking]
[move] enhance vouch system [breaking]
Aug 12, 2024
soaresa
force-pushed
the
breaking/enhance_vouch_system
branch
from
August 12, 2024 18:19
34905f9
to
a379f5f
Compare
0o-de-lally
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reviewed prior with @soaresa
sets vouch price on epoch boundary fixes calculate_min_vouches_required tests fixes vouch functions acquires
soaresa
force-pushed
the
breaking/enhance_vouch_system
branch
from
August 13, 2024 17:49
a379f5f
to
223ce8e
Compare
Closed
0o-de-lally
pushed a commit
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the enhancements to the voucher system as outlined in issue #298.
Objective:
The update aims to improve security, enhance reliability, and ensure greater active participation of validators in the social consensus. These changes are designed to prevent Sybil attacks, manage validator eligibility more effectively, and maintain overall network stability.
Key Updates:
Data Migrations: Introduced new resources:
ReceivedVouches
andGivenVouches
, and removed theMyVouches
resource to streamline the voucher tracking process.Migrations Module: Developed a new
Migrations
module to manage and centralize data migration execution. This module records migration history, including the migration number, epoch, and description. All migrations will be executed at the start of each epoch boundary.These improvements aim to create a more secure and reliable framework for tracking and managing vouches, thereby supporting the network's stability and integrity.
Move Test Coverage:
Move Test Coverage Score per Module:
*new migrations module will have 100% test coverage in the very next migration.