Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/integrate latest rocksb6.20+ #1

Merged
merged 77 commits into from
Jan 26, 2022
Merged

Fix/integrate latest rocksb6.20+ #1

merged 77 commits into from
Jan 26, 2022

Conversation

ssardana96
Copy link

No description provided.

ananclub and others added 30 commits October 19, 2016 13:13
@ananclub
fix windows dynamic build crash
e08b908
@ananclub
Merge remote-tracking branch 'remotes/upstream/master'
533a9e9 
# Conflicts:
#	options.go
@ananclub
use rocksdb_free for release
eff08f0
@olebedev
add wal iterator
fc04b74
@jialeicui
add wrapper for GetOptionsFromString
2280d59
@bmermet
Add GetStatisticsString method to Options
e0ef1dd
fix memory leak in deleting filterpolicy and mergeoperator value
28210cc
@paulmach
fix GetApproximateSizes
f1ea5ee
@rupertchen
Add support for opening a db with TTL support
65e4f3a
@rupertchen
Add *DB.SetOptions().
41daeed
DeleteRange DeleteRangeCF
c32be75
@jackwakefield
Add pinned slices
53f98ff
@tecbot
Merge pull request tecbot#156 from rupertchen/open-with-ttl
5709d75 
Add support for opening a db with TTL support
@tecbot
Merge pull request tecbot#160 from applinskinner/pinned
e56d531 
Add pinnable slice
@tecbot
Merge pull request tecbot#155 from rupertchen/set-options
d8a660f 
Add *DB.SetOptions().
@tecbot
Merge pull request tecbot#153 from paulmach/fix-approx-sizes
330989c 
fix GetApproximateSizes
@tecbot
Merge pull request tecbot#151 from bmermet/statistics_string
28ce0c0 
Add GetStatisticsString method to Options
@tecbot
Merge pull request tecbot#150 from jialeicui/rocksdb_get_options_from…
8e5cf18 
…_string

add wrapper for GetOptionsFromString
@tecbot
Merge pull request tecbot#152 from NgaiShunChan/fix-memory-leak
025c3cf 
fix memory leak in deleting filterpolicy and mergeoperator value
@artemyarulin
Correct default value for SetWriteBufferSize
3e9dad2 
According to https://github.com/facebook/rocksdb/wiki/Setup-Options-and-Basic-Tuning#column-family-write-buffer-size default for `SetWriteBufferSize` should be `64MB` and not `4MB`
DeleteFileInRange
acc24fc
Merge branch 'master' of https://github.com/tecbot/gorocksdb
89a20de 
* 'master' of https://github.com/tecbot/gorocksdb:
  Add pinned slices
  Add *DB.SetOptions().
  Add support for opening a db with TTL support
  fix GetApproximateSizes
  fix memory leak in deleting filterpolicy and mergeoperator value
  Add GetStatisticsString method to Options
  add wrapper for GetOptionsFromString
DeleteFileInRange and comments
ea499c0
add test for DeleteRange
ce1489d
change int to uint64
5444b9d
add SetEnablePipelinedWrite
a5447a1
Merge branch 'master' of https://github.com/gritzko/gorocksdb
f35f041
improve the PR of wal iterator
96eadb8
format code
930ad62
add err ret for GetUpdatesSince
20a9aac
tecbot and others added 20 commits September 24, 2019 21:58
@tecbot
Merge pull request tecbot#162 from GetStream/add-lower-priority-c-bin…
759d835 
…dings-pr

Add bindings for lowering CPU and IO priority of thread pools
@tecbot
Merge pull request tecbot#173 from michilu/fix/issues-145-build-error…
f3d486e 
…-on-armhf

Workaround for Linux 32-bit build
@ananclub
Merge pull request #1 from tecbot/master
bbab159 
merge master changes
use rocksdb_free to fix windows run crash
f43d6ee
@tecbot
Revert "Add bindings for lowering CPU and IO priority of thread pools"
bb1c9e9
@tecbot
Merge pull request tecbot#176 from tecbot/revert-162-add-lower-priori…
1ddf313 
…ty-c-bindings-pr

Revert "Add bindings for lowering CPU and IO priority of thread pools"
@jamesbibby
Merge pull request tecbot#119 from ananclub/master
65a88f0 
use rocksdb_free
@jamesbibby
Attempting to destroy the opts.cst will segfault
55ce39d 
Reference: facebook/rocksdb#1095

The cst has alredy been consumed when associated with the prefix_extractor
@jamesbibby
Merge pull request tecbot#174 from Stumble/yumin/remove-flags
d217d93 
remove compression library link flags.
@kr-mohak
Add CreateNewBackupFlush alongside CreateNewBackup
a1e313d 
CreateNewBackupFlush, when flush is set to true, flushes the WAL
before creating the backup. When flush is set to false, it acts
exactly like CreateNewBackup and backups the WAL in a separate,
non-atomic operation.
@kr-mohak
Add the method PurgeOldBackups to BackupEngine
1c5d8be
@jamesbibby
Merge pull request tecbot#178 from kr-mohak/backup-improvements
400c562 
Backup improvements
@kenny-house
Add missing table options and full bloom filter
343ac07
@ferhatelmas
Adjust go versions in travis
b74127c 
fixes tecbot#183
@jamesbibby
Merge pull request tecbot#184 from ferhatelmas/go-versions
712d449 
Adjust go versions in travis
@jamesbibby
Merge pull request tecbot#181 from kenny-house/partitioned-index-options
a180c0b 
Add missing table options and full bloom filter
@jamesbibby
Merge pull request tecbot#180 from tecbot/dont-destroy-cst
eb0a0d0 
Attempting to destroy the opts.cst will segfault
@flxflx
add NewMemEnv
bbc5fe7
@jamesbibby
Merge pull request tecbot#187 from edgelesssys/master
f0fad39 
Add function to create MemEnv
@ssardana08
- fix for latest rocksdb
9721107
kushthedude
kushthedude suggested changes Jan 25, 2022
View reviewed changes
Copy link

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we maintaining a fork when there are no changes, or if some changes we need why arent we contributing to the upstream & increasing our tech debt?

@cnlangzi
Copy link

Why are we maintaining a fork when there are no changes, or if some changes we need why arent we contributing to the upstream & increasing our tech debt?

some patches are added on the fork. see 9721107

@cnlangzi cnlangzi requested a review from kushthedude January 26, 2022 00:29
@cnlangzi
Copy link

cnlangzi commented Jan 26, 2022 •
edited
Loading

only 6.20.3 works on Apple M1 chip. but gorocksdb is broken by rocksdb public api changes since v6.16.0 https://github.com/facebook/rocksdb/blob/e8f116deabc601a5eae011f2fd8a38d02d87be8d/HISTORY.md#public-api-change-13

rocksdb_approximate_sizes and rocksdb_approximate_sizes_cf in the C API now requires an error pointer (char** errptr) for receiving any error.

if we want to debug sharder on Apple M1 chip, rocksdb has to be upgraded to v6.20.3, and rocksdb_approximate_sizes and rocksdb_approximate_sizes_cf should be fixed on gorocksdb too. check issue on tecbot#203

@ssardana08 could you try to send a PR to tecbot/gorocksdb too? we can drop our fork if it is fixed on tecbot/gorocksdb

@ssardana96
Copy link
Author

@cnlangzi look like there is already a PR opened for the same since March 2021 on the upstream, but not merged
tecbot#210

@kushthedude
Copy link

Lets get it in since the fork as well as the main library has not been maintained.

@kushthedude kushthedude merged commit 31547a9 into master Jan 26, 2022
@cnlangzi cnlangzi deleted the fix/integrate_latest_rocksb6.20+ branch February 10, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushthedude kushthedude kushthedude approved these changes

@cnlangzi cnlangzi cnlangzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.