fix(lsp): prevent crash with empty list of definitions (#271)

0no-co · Mar 20, 2024 · 3c4586c · 3c4586c
1 parent 8c79c98
commit 3c4586c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/rotten-stingrays-kick.md b/.changeset/rotten-stingrays-kick.md
@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+Fix case where our fragments is an empty array
diff --git a/packages/graphqlsp/src/ast/index.ts b/packages/graphqlsp/src/ast/index.ts
@@ -58,7 +58,7 @@ function unrollFragment(
     element.getStart()
   );
 
-  if (!definitions) return fragments;
+  if (!definitions || !definitions.length) return fragments;
 
   const [fragment] = definitions;
 
@@ -159,7 +159,7 @@ export function getAllFragments(
     fileName,
     node.expression.getStart()
   );
-  if (!definitions) return fragments;
+  if (!definitions || !definitions.length) return fragments;
 
   if (node.arguments[1] && ts.isArrayLiteralExpression(node.arguments[1])) {
     const arg2 = node.arguments[1] as ts.ArrayLiteralExpression;

diff --git a/packages/graphqlsp/src/ast/resolve.ts b/packages/graphqlsp/src/ast/resolve.ts
@@ -38,7 +38,7 @@ export function resolveTemplate(
           filename,
           span.expression.getStart()
         );
-        if (!definitions) return;
+        if (!definitions || !definitions.length) return;
 
         const def = definitions[0];
         const src = getSource(info, def.fileName);