Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overrides for ValveAccessory #376

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Conversation

monkeycatdog
Copy link

Hey everyone, happy to use this plugin.
There are some issues with ValveAccessory, figured out the reason.

@monkeycatdog
Copy link
Author

Related to
#235

@0x5e
Copy link
Owner

0x5e commented Sep 23, 2023

@monkeycatdog thanks, I'm busy at school these days, I will check it later.

@0x5e
Copy link
Owner

0x5e commented Sep 28, 2023

For Valve Accessory currently I only display the boolean schema with "switch" prefix to hide some unused schemas. What schema do you want to show up? @monkeycatdog

@monkeycatdog
Copy link
Author

Previously, it was ignoring overrides. My valve with non-standard schema was not supported. For now, valve can be overridden as well. @0x5e

@0x5e 0x5e merged commit bf6f551 into 0x5e:develop_1.7.0 Sep 30, 2023
8 checks passed
@0x5e
Copy link
Owner

0x5e commented Sep 30, 2023

thanks @monkeycatdog , beta.50 updated.

@twei7
Copy link

twei7 commented Oct 14, 2023

Hi, commit bf6f551 seems to cause a regression.
I have a device that has 4 switches (category set as ggq). Before the change, they can show up as a group with 5 buttons correctly. But with this change, only the first switch (switch_1) is shown.
I revert the change in my home bridge and all switch buttons come back.

"category": "kg",
    "functions": [
      {
        "code": "switch_1",
        "type": "Boolean",
        "values": "{}"
      },
      {
        "code": "switch_2",
        "type": "Boolean",
        "values": "{}"
      },
      {
        "code": "switch_3",
        "type": "Boolean",
        "values": "{}"
      },
      {
        "code": "switch_4",
        "type": "Boolean",
        "values": "{}"
      },
      {
        "code": "countdown_1",
        "type": "Integer",
        "values": "{\"unit\":\"s\",\"min\":0,\"max\":86400,\"scale\":0,\"step\":1}"
      },
      {
        "code": "countdown_2",
        "type": "Integer",
        "values": "{\"unit\":\"s\",\"min\":0,\"max\":86400,\"scale\":0,\"step\":1}"
      },
      {
        "code": "countdown_3",
        "type": "Integer",
        "values": "{\"unit\":\"s\",\"min\":0,\"max\":86400,\"scale\":0,\"step\":1}"
      },
      {
        "code": "countdown_4",
        "type": "Integer",
        "values": "{\"unit\":\"s\",\"min\":0,\"max\":86400,\"scale\":0,\"step\":1}"
      },
      {
        "code": "switch_all",
        "type": "Boolean",
        "values": "{}"
      },
      {
        "code": "power_status",
        "type": "Boolean",
        "values": "{}"
      },
      {
        "code": "dev_mode",
        "type": "Enum",
        "values": "{\"range\":[\"selflock\",\"inching\",\"interlock\"]}"
      },
      {
        "code": "jg_time",
        "type": "Integer",
        "values": "{\"unit\":\"S\",\"min\":5,\"max\":600,\"scale\":1,\"step\":5}"
      }
    ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants