Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve per request log metadata #1307

Closed
ThinkChaos opened this issue Dec 18, 2023 · 3 comments
Closed

Improve per request log metadata #1307

ThinkChaos opened this issue Dec 18, 2023 · 3 comments
Labels
🛑 blocked Waiting for external dependency 🔨 enhancement New feature or request

Comments

@ThinkChaos
Copy link
Collaborator

It would be nice to have something like a request ID being logged with each log that relates to a specific request to make tracing a request's path easier, and possible to discern logs from different requests.

Should pretty straightforward after logs automatically pickup the request's log via a context (see #1264).

Also in the server we should log how we received the request (TCP/UDP/..., the port, etc.).

@ThinkChaos ThinkChaos added 🔨 enhancement New feature or request 🛑 blocked Waiting for external dependency labels Dec 18, 2023
@0xERR0R
Copy link
Owner

0xERR0R commented Dec 19, 2023

👍 that sounds good. We could either generate a unique id (maybe not so long as uuid) or take a message ID from the DNS request.

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@ThinkChaos
Copy link
Collaborator Author

Done in #1356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 blocked Waiting for external dependency 🔨 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants