refactor(log): store log in context so it's automatically propagated #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1356 +/- ##
==========================================
+ Coverage 93.88% 94.24% +0.35%
==========================================
Files 78 78
Lines 6361 4933 -1428
==========================================
- Hits 5972 4649 -1323
+ Misses 300 194 -106
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
ThinkChaos
commented
Jan 28, 2024
|
This looks nice |
kwitsch
reviewed
Jan 30, 2024
BenMcH
approved these changes
Feb 11, 2024
RFC 8484 Section 4.2.1: > A successful HTTP response with a 2xx status code (see > Section 6.3 of RFC7231) is used for any valid DNS response, > regardless of the DNS response code. For example, a successful 2xx > HTTP status code is used even with a DNS message whose DNS response > code indicates failure, such as SERVFAIL or NXDOMAIN. https://www.rfc-editor.org/rfc/rfc8484#section-4.2.1
ThinkChaos
force-pushed
the
refactor/log-ctx
branch
from
b970b15
to
7d8f30f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I had mentioned in #1264, this stores the logger in the
Contextwe pass around during resolving. This helps better propagate log fields.The most user visible impact is
prefixnow contains more resolvers in the chain.There's also a new
req_idfield that's a unique ID per request which will making following logs during debug easier (related to #1307).I also changed
util.LogOnErrorto get the log from a context, and removedmodel.Request.Log.