Rueidis base #1008

kwitsch · 2023-04-30T21:16:46Z

Redis rework #945

Rewrite current logic to use rueidis

Currently no unit tests as they have to be rewritten and the logic changes with forther implementation of the ticket.

…y test environment)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.1+incompatible to 23.0.3+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v23.0.1...v23.0.3) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [gorm.io/gorm](https://github.com/go-gorm/gorm) from 1.24.7-0.20230306060331-85eaf9eeda11 to 1.25.0. - [Release notes](https://github.com/go-gorm/gorm/releases) - [Commits](https://github.com/go-gorm/gorm/commits/v1.25.0) --- updated-dependencies: - dependency-name: gorm.io/gorm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [gorm.io/driver/sqlite](https://github.com/go-gorm/sqlite) from 1.4.4 to 1.5.0. - [Release notes](https://github.com/go-gorm/sqlite/releases) - [Commits](go-gorm/sqlite@v1.4.4...v1.5.0) --- updated-dependencies: - dependency-name: gorm.io/driver/sqlite dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [gorm.io/driver/mysql](https://github.com/go-gorm/mysql) from 1.4.7 to 1.5.0. - [Release notes](https://github.com/go-gorm/mysql/releases) - [Commits](go-gorm/mysql@v1.4.7...v1.5.0) --- updated-dependencies: - dependency-name: gorm.io/driver/mysql dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/swaggo/swag](https://github.com/swaggo/swag) from 1.8.12 to 1.16.1. - [Release notes](https://github.com/swaggo/swag/releases) - [Changelog](https://github.com/swaggo/swag/blob/master/.goreleaser.yml) - [Commits](swaggo/swag@v1.8.12...v1.16.1) --- updated-dependencies: - dependency-name: github.com/swaggo/swag dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/alicebob/miniredis/v2](https://github.com/alicebob/miniredis) from 2.30.1 to 2.30.2. - [Release notes](https://github.com/alicebob/miniredis/releases) - [Changelog](https://github.com/alicebob/miniredis/blob/master/CHANGELOG.md) - [Commits](alicebob/miniredis@v2.30.1...v2.30.2) --- updated-dependencies: - dependency-name: github.com/alicebob/miniredis/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

* use zig for goreleaser * added test workflow * Revert "added test workflow" This reverts commit 9c55c5f. * added goreleaser test * autorun goreleaser tests * add pseudo tag for goreleaser * added test * added arm test * arch test * missing qemu setup? * test alternate run * test rework * path fix? * 18 won't run * another test * permission fix * amd64 matrix * added macos * added windows test * consolidate unix tests * fix path * fix path2 * matrix consolidation * +x fails on macos * fix runner * windows fix * Update .github/workflows/goreleaser-test.yml Co-authored-by: ThinkChaos <[email protected]> * Update .github/workflows/goreleaser-test.yml Co-authored-by: ThinkChaos <[email protected]> * Update .github/workflows/goreleaser-test.yml Co-authored-by: ThinkChaos <[email protected]> * Update .github/workflows/goreleaser-test.yml Co-authored-by: ThinkChaos <[email protected]> * auto test binaries on release --------- Co-authored-by: ThinkChaos <[email protected]>

Bumps [github.com/avast/retry-go/v4](https://github.com/avast/retry-go) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/avast/retry-go/releases) - [Commits](avast/retry-go@4.3.3...4.3.4) --- updated-dependencies: - dependency-name: github.com/avast/retry-go/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

# Conflicts: # go.mod # go.sum

kwitsch · 2023-04-30T21:17:48Z

@ThinkChaos I moved the context as you requested in my previous PR.

codecov · 2023-04-30T21:22:54Z

Codecov Report

Patch coverage: 40.25% and project coverage change: -1.53 ⚠️

Comparison is base (8d48a21) 93.53% compared to head (13c8577) 92.01%.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           fb-redis-integration    #1008      +/-   ##
========================================================
- Coverage                 93.53%   92.01%   -1.53%     
========================================================
  Files                        63       63              
  Lines                      5323     5185     -138     
========================================================
- Hits                       4979     4771     -208     
- Misses                      269      334      +65     
- Partials                     75       80       +5

Impacted Files	Coverage Δ
resolver/blocking_resolver.go	`91.52% <0.00%> (-6.30%)`	⬇️
resolver/caching_resolver.go	`88.63% <0.00%> (-9.10%)`	⬇️
server/server.go	`77.06% <20.00%> (-1.89%)`	⬇️
config/redis.go	`41.66% <41.66%> (ø)`
config/config.go	`76.49% <100.00%> (ø)`

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ThinkChaos

I'm not the best person to review Redis stuff, but the context usage seems good!

config/config.go

config/redis.go

redis/redis.go

e2e/redis_test.go

resolver/blocking_resolver_test.go

config/config.go

Co-authored-by: ThinkChaos <[email protected]>

…into rueidis-base

0xERR0R

Looks good, good job! Please check my comments? I think it would be better to merge this PR on "fb-redis-integration" branch and not main, what do you think?

redis/redis.go

kwitsch · 2023-05-04T16:56:49Z

I think it would be better to merge this PR on "fb-redis-integration" branch and not main, what do you think?

Sorry I completely forgot that branch. 🤦‍♂️
I'll change it.

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.15.0 to 1.15.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.15.0...v1.15.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

kwitsch and others added 28 commits April 1, 2023 01:14

updated Deprecated comments

a92fdd3

moved redis config t seperate file

83eba7c

added more ruedis options

5d2420a

fmt,lint&test

56d181c

init ruedis

3d04477

ruedis init

fe575d6

ruedis rework

693617e

go mod tidy

b162f92

redis unit test 1

1761801

changed redis config validation

a748b73

go generate

583c632

unshadow

56d075a

removed all redis unit tests

f09cebc

fix e2e tests

f4d1722

removed one e2e test as it fails(even when a similar setup works in m…

4b13807

…y test environment)

e2e timing problem

7442d08

Merge remote-tracking branch 'origin/main' into rueidis-base

dded3ef

# Conflicts: # go.mod # go.sum

go mod tidy

e1d1443

don't store context in client

3bc152f

ThinkChaos reviewed May 1, 2023

View reviewed changes

kwitsch and others added 2 commits May 1, 2023 20:45

Update redis/redis.go

634a6da

Co-authored-by: ThinkChaos <[email protected]>

Update redis/redis.go

144a6a8

Co-authored-by: ThinkChaos <[email protected]>

0xERR0R self-requested a review May 2, 2023 06:58

kwitsch added 7 commits May 2, 2023 15:53

moved ClientOptions getter to config package

e1447a5

Merge branch 'rueidis-base' of https://github.com/kwitsch/blocky-dev …

ea517f1

…into rueidis-base

moved validation functions

9e0f789

linter fix

146f0b5

log warnings about config ignore

3e5094c

log fetch error

4ae0204

%w is not supported

d1c7c2f

0xERR0R reviewed May 4, 2023

View reviewed changes

redis/redis.go Outdated Show resolved Hide resolved

redis/redis.go Show resolved Hide resolved

kwitsch changed the base branch from main to fb-redis-integration May 4, 2023 18:22

dependabot bot and others added 4 commits May 5, 2023 07:58

retry.Do implementation

ad1ce3a

Merge branch 'main' into rueidis-base

5eb9371

log redis config if enabled

13c8577

kwitsch merged commit 804ba05 into 0xERR0R:fb-redis-integration May 5, 2023

kwitsch deleted the rueidis-base branch May 5, 2023 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rueidis base #1008

Rueidis base #1008

kwitsch commented Apr 30, 2023

kwitsch commented Apr 30, 2023

codecov bot commented Apr 30, 2023 •

edited

Loading

ThinkChaos left a comment

0xERR0R left a comment

kwitsch commented May 4, 2023

Rueidis base #1008

Rueidis base #1008

Conversation

kwitsch commented Apr 30, 2023

kwitsch commented Apr 30, 2023

codecov bot commented Apr 30, 2023 • edited Loading

Codecov Report

ThinkChaos left a comment

Choose a reason for hiding this comment

0xERR0R left a comment

Choose a reason for hiding this comment

kwitsch commented May 4, 2023

codecov bot commented Apr 30, 2023 •

edited

Loading