Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cache entire DNS response (#833) #909

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Mar 3, 2023

Changing cache behavior:

Before this change:
Cache in caching resolver could contain either the answer slice (from positive DNS response) or the result code (as int).

After this change:
Cache contains always the entire DNS response (dns.Msg)

fixes #833

@0xERR0R 0xERR0R added this to the 0.21 milestone Mar 3, 2023
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (d64b399) 93.15% compared to head (ce983ef) 93.06%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #909      +/-   ##
===============================================
- Coverage        93.15%   93.06%   -0.09%     
===============================================
  Files               42       42              
  Lines             4950     4945       -5     
===============================================
- Hits              4611     4602       -9     
- Misses             268      271       +3     
- Partials            71       72       +1     
Impacted Files Coverage Δ
resolver/caching_resolver.go 96.37% <100.00%> (-0.10%) ⬇️
resolver/query_logging_resolver.go 95.62% <0.00%> (-2.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alpominth
Copy link

Very good work. =)

An interesting feature that would be useful to use with this is #897.

I hope you implement some day.

@0xERR0R 0xERR0R merged commit 7da4724 into development Mar 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the fb-cache-entire-response branch March 3, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache entire DNS response and not only the answer section
4 participants