Support handling for more variability in markdown title lines #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://library-pr-7.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cd0a46qrrk0bm36jflqg. |
paulczajka
commented
Oct 7, 2022
| @@ -108,39 +120,46 @@ const IMPACT_LABEL_RE = /(?:\*\*)?Impact(?:\*\*)?:(?:\*\*)? ([^\n]+)?/ | |||
| const CHANCE_LABEL_RE = /(?:\*\*)?Likelihood(?:\*\*)?:(?:\*\*)? ([^\n]+)?/ | |||
|
|
|||
| exports.parseNotionMarkdownIssues = function parseNotionMarkdownIssues(markdown) { | |||
| return markdown.split(/(?=##\s+\([CHMLQGI]-\d\))/) | |||
| return markdown.split(new RegExp(`(?=${TITLE_LINE_RE})`)) | |||
There was a problem hiding this comment.
I wasn't able to get the Issue Formatter to work with pasting in multiple issues at once: either before or after these changes. Not sure if this was working yet? I've just been pasting them in one-at-a-time for now.
|
Nice! There's now a test file for parsing markdown content 😎 Can you add a few tests for the new formats, as well as the old one for backwards compat? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Issue Formatter to process a wider array of markdown issue title formats. Then normalize them into a single Final Report format.
Example Markdown Issue title formats we've used:
After normalizing for the Final Report: