Skip to content

Remove low-level Miden SDK WIT interfaces in favor of rlib stub library #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Sep 17, 2025
Merged

Remove low-level Miden SDK WIT interfaces in favor of rlib stub library #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
348a1fa
feature: try rlib stub for `miden::account::add_asset`
greenhat Aug 28, 2025
f92955b
feature: lower function stub to MASM procedure call
greenhat Aug 29, 2025
555259e
refactor: extract rlib stub compilation into the separate module
greenhat Aug 29, 2025
3813231
feature: convert `hmerge` intrinsic to use stub function instead of W…
greenhat Aug 29, 2025
4415629
feature: convert `add` felt intrinsic to use stub library instead of …
greenhat Aug 29, 2025
7048aa1
feature: convert all `intrinsics::felt` to use .rlib stub library
greenhat Sep 2, 2025
17e2233
chore: update expected files after rebase
greenhat Sep 2, 2025
58eddac
feature: convert the rest of the `intrinsics` to use .rlib stub library
greenhat Sep 2, 2025
49ed10f
refactor: don't hard-code file names of the .rlib stub library
greenhat Sep 2, 2025
568c001
feature: convert stdlib functions to use .rlib stub library
greenhat Sep 2, 2025
5fa82b1
feature: convert all the miden-base functions to use .rlib stub library
greenhat Sep 2, 2025
bcc1b2b
refactor: split .rlib stub library further into submodules
greenhat Sep 2, 2025
cb8f49a
chore: remove all the low-level Miden SDK WIT interface handling
greenhat Sep 2, 2025
bba9187
fix: update new project templates tag to v0.15.0
greenhat Sep 3, 2025
0c97713
refactor: move .rlib stub library compilation closer to rustc flags
greenhat Sep 3, 2025
7b77f32
refactor: move the miden-base-sys stubs into the crate's build.rs
greenhat Sep 4, 2025
1d5a10d
refactor: move the miden-stdlib-sys stubs into the crate's build.rs
greenhat Sep 4, 2025
7975d60
refactor: split and move the rlib stub library compilation and linkin…
greenhat Sep 5, 2025
23a1345
chore: update expected files after rebase
greenhat Sep 5, 2025
19b5fa6
refactor: ensure that a stub function body has only `unreachable` op;
greenhat Sep 5, 2025
1df6cd7
chore: clean commented code and clarify comments
greenhat Sep 5, 2025
37b2d48
chore: remove unused code
greenhat Sep 5, 2025
5dfbd9a
refactor: add error handling in module_translation_state.rs
greenhat Sep 5, 2025
e3c7682
fix: insure `cargo-binutils` are installed in build.rs handling stubs
greenhat Sep 5, 2025
18c17c4
refactor: extract abs path, remove redundant `RUSTFLAGS` `debuginfo` …
greenhat Sep 5, 2025
d6a13ea
chore: remove function skip list for `wit-bindgen` since we're not do…
greenhat Sep 5, 2025
219e939
chore!: version Miden SDK crates separately and set to v0.5.0
greenhat Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ MIDENC_BUILD_PROFILE = "release"

[tasks.init]
run_task = "print-env"
# Install proxies to the `llvm-tools` component, i.e. `rust-ar` proxy to the
# LLVM `ar` needed to build stub libraries (see `build.rs` in `*-sys` crates)
install_crate = { crate_name = "cargo-binutils" }

[tasks.default]
category = "Build"
Expand Down
12 changes: 6 additions & 6 deletions examples/basic-wallet-tx-script/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions examples/basic-wallet-tx-script/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ project-kind = "transaction-script"

[package.metadata.component.target.dependencies]
"miden:base" = { path = "../../sdk/base/wit/miden.wit" }
"miden:core-intrinsics" = { path = "../../sdk/stdlib-sys/wit/miden-core-intrinsics.wit" }
"miden:core-stdlib" = { path = "../../sdk/stdlib-sys/wit/miden-core-stdlib.wit" }
"miden:core-base" = { path = "../../sdk/base-sys/wit/miden-core-base.wit" }
"miden:basic-wallet" = { path = "../basic-wallet/wit/basic-wallet.wit" }

[profile.release]
Expand Down
4 changes: 0 additions & 4 deletions examples/basic-wallet-tx-script/wit/interface.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
package miden:[email protected];

world basic-wallet-tx-script-world {
include miden:core-intrinsics/[email protected];
include miden:core-stdlib/[email protected];
include miden:core-base/[email protected];

import miden:basic-wallet/[email protected];
export miden:base/[email protected];
}
12 changes: 6 additions & 6 deletions examples/basic-wallet/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions examples/basic-wallet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ supported-types = ["RegularAccountUpdatableCode"]

[package.metadata.component.target.dependencies]
"miden:base" = { path = "../../sdk/base/wit/miden.wit" }
"miden:core-intrinsics" = { path = "../../sdk/stdlib-sys/wit/miden-core-intrinsics.wit" }
"miden:core-stdlib" = { path = "../../sdk/stdlib-sys/wit/miden-core-stdlib.wit" }
"miden:core-base" = { path = "../../sdk/base-sys/wit/miden-core-base.wit" }

[profile.release]
trim-paths = ["diagnostics", "object"]
Expand Down
4 changes: 0 additions & 4 deletions examples/basic-wallet/wit/basic-wallet.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,5 @@ interface basic-wallet {
}

world basic-wallet-world {
include miden:core-intrinsics/[email protected];
include miden:core-stdlib/[email protected];
include miden:core-base/[email protected];

export basic-wallet;
}
12 changes: 6 additions & 6 deletions examples/counter-contract/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions examples/counter-contract/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,4 @@ supported-types = ["RegularAccountUpdatableCode"]

[package.metadata.component.target.dependencies]
"miden:base" = { path = "../../sdk/base/wit/miden.wit" }
"miden:core-intrinsics" = { path = "../../sdk/stdlib-sys/wit/miden-core-intrinsics.wit" }
"miden:core-stdlib" = { path = "../../sdk/stdlib-sys/wit/miden-core-stdlib.wit" }
"miden:core-base" = { path = "../../sdk/base-sys/wit/miden-core-base.wit" }

4 changes: 0 additions & 4 deletions examples/counter-contract/wit/counter.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,5 @@ interface counter {
}

world counter-world {
include miden:core-intrinsics/[email protected];
include miden:core-stdlib/[email protected];
include miden:core-base/[email protected];

export counter;
}
12 changes: 6 additions & 6 deletions examples/counter-note/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions examples/counter-note/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ package = "miden:counter-note"

[package.metadata.component.target.dependencies]
"miden:base" = { path = "../../sdk/base/wit/miden.wit" }
"miden:core-intrinsics" = { path = "../../sdk/stdlib-sys/wit/miden-core-intrinsics.wit" }
"miden:core-stdlib" = { path = "../../sdk/stdlib-sys/wit/miden-core-stdlib.wit" }
"miden:core-base" = { path = "../../sdk/base-sys/wit/miden-core-base.wit" }
"miden:counter-contract" = { path = "../counter-contract/wit/counter.wit" }

[profile.release]
Expand Down
4 changes: 0 additions & 4 deletions examples/counter-note/wit/counter-note.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
package miden:[email protected];

world counter-note-world {
include miden:core-intrinsics/[email protected];
include miden:core-stdlib/[email protected];
include miden:core-base/[email protected];

import miden:counter-contract/[email protected];
export miden:base/[email protected];
}
Loading