Skip to content

updated StorageMapAccess::get return Option<V> #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

updated StorageMapAccess::get return Option<V> #676

wants to merge 1 commit into from

Conversation

PoulavBhowmick03
Copy link

Fixes #673

@PoulavBhowmick03 PoulavBhowmick03 changed the title updated StorageMapAccess::get return Option<V> updated StorageMapAccess::get return Option<V> Sep 14, 2025
greenhat
greenhat requested changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please check my comment.

sdk/base/src/types/storage.rs
fn get(&self, key: &K) -> V {
storage::get_map_item(self.slot, key.as_ref()).into()
fn get(&self, key: &K) -> Option<V> {
Some(storage::get_map_item(self.slot, key.as_ref()).into())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to test if get_map_item returns zero word and if so - return None. See the Why section in #673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenhat greenhat greenhat requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK: make StorageMapAccess::get return Option<V>
2 participants
@PoulavBhowmick03 @greenhat