Skip to content

Fix self destruct in parallel evm #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
+29 −1
Merged

Fix self destruct in parallel evm #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d8a61f
Fix selfdestruct for parallel execution
avalkov Oct 14, 2025
f9a3e8d
Added unit test for parallel evm selfdestruct
avalkov Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/state/statedb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ func (s *StateDB) ApplyMVWriteSet(writes []blockstm.WriteDescriptor) {
case CodePath:
s.SetCode(addr, sr.GetCode(addr))
case SuicidePath:
stateObject := sr.getStateObject(addr)
stateObject := s.getStateObject(addr)
if stateObject != nil {
s.SelfDestruct(addr)
}
Expand Down
28 changes: 28 additions & 0 deletions core/state/statedb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,3 +1997,31 @@ func TestStorageDirtiness(t *testing.T) {
state.RevertToSnapshot(snap)
checkDirty(common.Hash{0x1}, common.Hash{0x1}, true)
}

func TestShouldDeleteSmartContractIfItExistsInState(t *testing.T) {
t.Parallel()

code := []byte{1, 2, 3}

db := NewDatabase(triedb.NewDatabase(rawdb.NewMemoryDatabase(), triedb.HashDefaults), nil)
mvhm := blockstm.MakeMVHashMap()
s, _ := NewWithMVHashmap(common.Hash{}, db, nil, mvhm)

addr := common.HexToAddress("0x01")
s.getOrNewStateObject(addr)
s.CreateContract(addr)
s.SetCode(addr, code)
s.Finalise(true)

secondDB := s.Copy()
secondDB.SelfDestruct(addr)

codeBeforeDeletion := s.GetCode(addr)
assert.Equal(t, code, codeBeforeDeletion, "smart contract should exist before deletion")

s.ApplyMVWriteSet(secondDB.MVWriteList())
s.Finalise(true)

codeAfterDeletion := s.GetCode(addr)
assert.Equal(t, []byte(nil), codeAfterDeletion, "smart contract should be deleted")
}
Loading