Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audit remediation] Suggestion 1: Adopt a Verifiable Database / Batch Format #100

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Jul 2, 2024

  • Added migration for adding batch_num column to offchain_data table.
    • The migration resets the last block number for L1 task in order to trigger resync process that will updated batch number in all existing records.
  • Updated DB layer logic to handle a new field.
  • Updated handleUnresolvedBatches function to populate a batch number field
    • It also populates a batch number field for existing records. This is needed to updated batch number in all existing records.

Copy link

sonarcloud bot commented Jul 2, 2024

@Stefan-Ethernal Stefan-Ethernal changed the title [Audit remdiation] Suggestion 1: Adopt a Verifiable Database / Batch Format [Audit remediation] Suggestion 1: Adopt a Verifiable Database / Batch Format Jul 3, 2024
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, though it is strange to me this part around having SyncTask as a type alias and providing it as a parameter, since it is always the L1SyncTask value.

synchronizer/store.go Show resolved Hide resolved
@begmaroman begmaroman merged commit 48558e6 into main Jul 3, 2024
8 of 9 checks passed
@begmaroman begmaroman deleted the feature/CDK-338 branch July 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants