Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace packr to embed #110

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Replace packr to embed #110

merged 1 commit into from
Jul 29, 2024

Conversation

begmaroman
Copy link
Contributor

No description provided.

@begmaroman begmaroman self-assigned this Jul 26, 2024
@begmaroman begmaroman requested a review from a team as a code owner July 26, 2024 15:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@begmaroman begmaroman merged commit 2e10263 into main Jul 29, 2024
7 of 9 checks passed
@begmaroman begmaroman deleted the feature/CDK-384 branch July 29, 2024 08:07
vcastellm
vcastellm reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm left review comments

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@begmaroman @vcastellm @Stefan-Ethernal