Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicates from offchain data #112

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Remove duplicates from offchain data #112

merged 6 commits into from
Aug 19, 2024

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Aug 13, 2024 •
edited
Loading

No description provided.

@begmaroman begmaroman self-assigned this Aug 13, 2024
@begmaroman begmaroman requested a review from a team as a code owner August 13, 2024 17:17
@begmaroman begmaroman changed the title Check offchain data for duplicates Remove duplicates from offchain data Aug 13, 2024
arnaubennassar
arnaubennassar requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@arnaubennassar arnaubennassar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the PR covers the case where there are duplicated inserts within the same query, but not if one of the items about to get inserted already exist on the DB

db/db.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@goran-ethernal
Copy link
Collaborator

Did we agree on the detection of batch gap, because we also index with Batch Number? It will now be more and more frequent since batches can have the same L2Data. Do we just log the gaps, and call it a day, or do we have some logic attached after we detect a gap? I don't recall.

@begmaroman begmaroman merged commit b48599a into main Aug 19, 2024
8 of 9 checks passed
@begmaroman begmaroman deleted the fix/CDK-423 branch August 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaubennassar arnaubennassar arnaubennassar approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@begmaroman @goran-ethernal @arnaubennassar